From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34175)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuEd-0000Wm-KC
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:41:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuEX-00031r-Ol
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:41:23 -0400
Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:46384)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuEX-00031j-Ku
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:41:17 -0400
Received: by mail-qc0-f178.google.com with SMTP id p19so1645840qcv.9
	for <qemu-devel@nongnu.org>; Mon, 26 Aug 2013 03:41:17 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <521B30C9.8060206@redhat.com>
Date: Mon, 26 Aug 2013 12:41:13 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377471536-12423-1-git-send-email-akoskovacs@gmx.com>
	<1377471536-12423-20-git-send-email-akoskovacs@gmx.com>
In-Reply-To: <1377471536-12423-20-git-send-email-akoskovacs@gmx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 19/47] hw/audio/Kconfig: Add audio Kconfig
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?w4Frb3MgS292w6Fjcw==?= <akoskovacs@gmx.com>
Cc: qemu-devel@nongnu.org

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <akoskovacs@gmx.com>
> ---
>  hw/audio/Kconfig |   41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 hw/audio/Kconfig
> 
> diff --git a/hw/audio/Kconfig b/hw/audio/Kconfig
> new file mode 100644
> index 0000000..bb6c31d
> --- /dev/null
> +++ b/hw/audio/Kconfig
> @@ -0,0 +1,41 @@
> +menu "Audio devices"
> +    config SB16
> +        bool
> +        #select ISA

All these should have "depends on ISA".


> +    config ES1370
> +        bool "ES1370"
> +        depends on PCI
> +
> +    config AC97
> +        bool "AC97 sound card"
> +        default y
> +        depends on PCI
> +
> +    config ADLIB
> +        bool
> +        #select ISA
> +
> +    config CS4231A
> +        bool
> +
> +    config HDA
> +        bool
> +        #select ISA
> +
> +    config PCSPK
> +        bool
> +        select I8254

Perhaps "depends on I8254"?

> +    config WM8750
> +        bool
> +
> +    config PL041
> +        bool
> +
> +    config CS4231
> +        bool
> +
> +    config MARVELL_88W8618
> +        bool
> +endmenu
>