From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuGO-0001u4-7B
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:43:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuGI-0003cx-DB
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:43:12 -0400
Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:52750)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuGI-0003ck-8O
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:43:06 -0400
Received: by mail-qc0-f175.google.com with SMTP id m4so1617905qcy.6
	for <qemu-devel@nongnu.org>; Mon, 26 Aug 2013 03:43:05 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <521B3135.9020203@redhat.com>
Date: Mon, 26 Aug 2013 12:43:01 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377471536-12423-1-git-send-email-akoskovacs@gmx.com>
	<1377471536-12423-21-git-send-email-akoskovacs@gmx.com>
In-Reply-To: <1377471536-12423-21-git-send-email-akoskovacs@gmx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 20/47] hw/block/Kconfig: Add Kconfig file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?w4Frb3MgS292w6Fjcw==?= <akoskovacs@gmx.com>
Cc: qemu-devel@nongnu.org

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <akoskovacs@gmx.com>
> ---
>  hw/block/Kconfig |   34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 hw/block/Kconfig
> 
> diff --git a/hw/block/Kconfig b/hw/block/Kconfig
> new file mode 100644
> index 0000000..400cab3
> --- /dev/null
> +++ b/hw/block/Kconfig
> @@ -0,0 +1,34 @@
> +config FDC
> +    bool
> +    #select ISA
> +
> +config SSI_M25P80
> +    bool
> +    select SSI
> +
> +config NAND
> +    bool
> +
> +config PFLASH_CFI01
> +    bool
> +
> +config PFLASH_CFI02
> +    bool
> +
> +config ECC
> +    bool
> +
> +config ONENAND
> +    bool
> +
> +config PC_SYSFW
> +    bool
> +    #select ISA

This is not anymore in the tree.

> +config NVME_PCI
> +    bool
> +    depends on PCI
> +
> +config VIRTIO_BLK_DATA_PLANE
> +    bool
> +    select VIRTIO

This is controlled by config-host.mak, so no need for it here.

Perhaps, similar to 9p, you could have

config VIRTIO_BLK
    bool
    default y
    depends on VIRTIO

but it can be added later, too.

Paolo