From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuHN-00053v-JM
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:44:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuHE-000496-29
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:44:13 -0400
Received: from mail-qa0-x22b.google.com ([2607:f8b0:400d:c00::22b]:36424)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuHD-00048y-UZ
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:44:03 -0400
Received: by mail-qa0-f43.google.com with SMTP id bq6so733677qab.9
	for <qemu-devel@nongnu.org>; Mon, 26 Aug 2013 03:44:03 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <521B316E.6070703@redhat.com>
Date: Mon, 26 Aug 2013 12:43:58 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377471536-12423-1-git-send-email-akoskovacs@gmx.com>
	<1377471536-12423-22-git-send-email-akoskovacs@gmx.com>
In-Reply-To: <1377471536-12423-22-git-send-email-akoskovacs@gmx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 21/47] hw/char/Kconfig: Add Kconfig file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?w4Frb3MgS292w6Fjcw==?= <akoskovacs@gmx.com>
Cc: qemu-devel@nongnu.org

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <akoskovacs@gmx.com>
> ---
>  hw/char/Kconfig |   24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 hw/char/Kconfig
> 
> diff --git a/hw/char/Kconfig b/hw/char/Kconfig
> new file mode 100644
> index 0000000..7ad0bd3
> --- /dev/null
> +++ b/hw/char/Kconfig
> @@ -0,0 +1,24 @@
> +config IPACK 
> +    bool
> +    depends on PCI

PCI devices are generally configurable, so you need to add prompts to them.

> +config ESCC
> +    bool
> +
> +config PARALLEL
> +    bool
> +    #select ISA

Also "depends on" here.  You probably also want to make all these ISA
devices configurable, so add a prompt.

Paolo

> +config SERIAL
> +    bool
> +    #select ISA
> +
> +config SERIAL_PCI
> +    bool
> +    depends on PCI
> +
> +config SCLPCONSOLE
> +    bool
> +
> +config PL011
> +    bool
>