From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35656)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuMB-0008Gx-To
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:49:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuM5-0005rJ-RX
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:49:11 -0400
Received: from mail-qe0-x22f.google.com ([2607:f8b0:400d:c02::22f]:53684)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuM5-0005rB-NN
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:49:05 -0400
Received: by mail-qe0-f47.google.com with SMTP id b4so1636528qen.20
	for <qemu-devel@nongnu.org>; Mon, 26 Aug 2013 03:49:05 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <521B329C.3090506@redhat.com>
Date: Mon, 26 Aug 2013 12:49:00 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377471536-12423-1-git-send-email-akoskovacs@gmx.com>
	<1377471536-12423-25-git-send-email-akoskovacs@gmx.com>
In-Reply-To: <1377471536-12423-25-git-send-email-akoskovacs@gmx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 24/47] hw/display/Kconfig: Add Kconfig file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?w4Frb3MgS292w6Fjcw==?= <akoskovacs@gmx.com>
Cc: qemu-devel@nongnu.org

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <akoskovacs@gmx.com>
> ---
>  hw/display/Kconfig |   84 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 84 insertions(+)
>  create mode 100644 hw/display/Kconfig
> 
> diff --git a/hw/display/Kconfig b/hw/display/Kconfig
> new file mode 100644
> index 0000000..1f6f386
> --- /dev/null
> +++ b/hw/display/Kconfig
> @@ -0,0 +1,84 @@
> +config ADS7846
> +    bool
> +    select SSI

Similarly this should be "depends on".  To put it more clearly:

- devices that are on a particular bus should "depend on" that bus;

- devices that expose a particular bus (for example a PCI host bridge)
should "select" it so that the user can choose which devices to enable
on that board

- devices can also "select" library features that they use, for example
FRAMEBUFFER or PTIMER, or "sub-devices" that they include, for example
VGA or what you did in I82378

- boards should also "select" devices, but you got that part right so no
need to explain :)

Paolo

> +config VGA_CIRRUS
> +    bool
> +    depends on PCI
> +    select VGA
> +    #select ISA
> +
> +config G364FB
> +    bool
> +
> +config JAZZ_LED
> +    bool
> +
> +config PL110
> +    bool
> +    select FRAMEBUFFER
> +
> +config SSD0303
> +    bool
> +    #select I2C
> +
> +config SSD0323
> +    bool
> +    select SSI
> +
> +config VGA_PCI
> +    bool
> +    select VGA
> +    depends on PCI
> +
> +config VGA_ISA
> +    bool
> +    select VGA
> +    #select ISA
> +
> +config VGA_ISA_MM
> +    bool
> +    select VGA
> +
> +config VMWARE_VGA
> +    bool
> +    select VGA
> +    depends on PCI
> +
> +config BLIZZARD
> +    bool
> +
> +config FRAMEBUFFER
> +    bool
> +
> +config MILKYMIST
> +    bool
> +    select FRAMEBUFFER
> +
> +config ZAURUS
> +    bool
> +    select NAND
> +    select ECC
> +
> +config OMAP
> +    bool
> +    select FRAMEBUFFER
> +
> +config PXA2XX
> +    bool
> +    select FRAMEBUFFER
> +
> +config MILKYMIST_TMU2
> +    bool
> +
> +config SM501
> +    bool
> +
> +config TCX
> +    bool
> +
> +config VGA
> +    bool
> +
> +config QXL
> +    bool
>