From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuWx-0005Xg-I9
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 07:00:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuWr-0001I2-At
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 07:00:19 -0400
Received: from mail-qa0-x231.google.com ([2607:f8b0:400d:c00::231]:55036)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuWr-0001Hw-69
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 07:00:13 -0400
Received: by mail-qa0-f49.google.com with SMTP id ia15so901544qab.15
	for <qemu-devel@nongnu.org>; Mon, 26 Aug 2013 04:00:12 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <521B3538.4090005@redhat.com>
Date: Mon, 26 Aug 2013 13:00:08 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377471536-12423-1-git-send-email-akoskovacs@gmx.com>
	<1377471536-12423-33-git-send-email-akoskovacs@gmx.com>
In-Reply-To: <1377471536-12423-33-git-send-email-akoskovacs@gmx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 32/47] hw/misc/Kconfig: Add Kconfig file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?w4Frb3MgS292w6Fjcw==?= <akoskovacs@gmx.com>
Cc: qemu-devel@nongnu.org

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <akoskovacs@gmx.com>
> ---
>  hw/misc/Kconfig |   67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 67 insertions(+)
>  create mode 100644 hw/misc/Kconfig
> 
> diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
> new file mode 100644
> index 0000000..5a6477f
> --- /dev/null
> +++ b/hw/misc/Kconfig
> @@ -0,0 +1,67 @@
> +config APPLESMC
> +    bool
> +    #select ISA
> +    
> +config MAX111X
> +    bool
> +    select SSI
> +
> +config TMP105
> +    bool
> +    #select I2C
> +
> +config ISA_DEBUG
> +    bool
> +    #select ISA
> +
> +config SGA
> +    bool
> +    #depends on PCI
> +
> +config ISA_TESTDEV
> +    bool
> +    #select ISA
> +
> +config PCI_TESTDEV
> +    bool
> +    depends on PCI
> +
> +config VMPORT
> +    bool
> +    #select ISA
> +
> +config PL310
> +    bool
> +
> +config PUV3
> +    bool
> +
> +config MACIO
> +    bool
> +    depends on PCI
> +    select MAC_NVRAM

Correct: this is a PCI device that embeds an MacIONVRAMState.

But it also embeds a MAC_DBDMA device, so "select MAC_DBDMA" too.

> +config CUDA
> +    bool
> +    select MACIO

Should be "select ADB" since this is a device that exposes an ADB bus.

> +config MAC_DBDMA
> +    bool   
> +    select MACIO
> +    select ADB
> +    #select ISA

Why these?  I think it doesn't need any of the three.

> +config A9SCU
> +    bool
> +
> +config ECCMEMCTL
> +    bool
> +    select ECC
> +
> +config OMAP
> +    bool
> +    select ECCMEMCTL
> +    select NAND
> +    
> +config PVPANIC
> +    bool
>