From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuaO-0000AO-9n
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 07:03:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuaI-0002Ue-91
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 07:03:52 -0400
Received: from mail-qc0-x22b.google.com ([2607:f8b0:400d:c01::22b]:61307)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuaI-0002UR-5t
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 07:03:46 -0400
Received: by mail-qc0-f171.google.com with SMTP id n1so1637572qcw.2
	for <qemu-devel@nongnu.org>; Mon, 26 Aug 2013 04:03:45 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <521B360D.60401@redhat.com>
Date: Mon, 26 Aug 2013 13:03:41 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377471536-12423-1-git-send-email-akoskovacs@gmx.com>
	<1377471536-12423-32-git-send-email-akoskovacs@gmx.com>
In-Reply-To: <1377471536-12423-32-git-send-email-akoskovacs@gmx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 31/47] hw/isa/Kconfig: Add Kconfig file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?w4Frb3MgS292w6Fjcw==?= <akoskovacs@gmx.com>
Cc: qemu-devel@nongnu.org

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <akoskovacs@gmx.com>
> ---
>  hw/isa/Kconfig |   42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 hw/isa/Kconfig
> 
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> new file mode 100644
> index 0000000..8b6baaf
> --- /dev/null
> +++ b/hw/isa/Kconfig
> @@ -0,0 +1,42 @@
> +#config ISA
> +#   bool

Why is it commented out?

> +config APM
> +    bool
> +
> +config I82378
> +    bool    
> +    #select ISA
> +    select I8259  # irq
> +    select PCSPK
> +    select I82374 # DMA
> +    select MC146818RTC # timer
> +    depends on PCI
> +
> +config ISA_MMIO
> +    bool
> +    #select ISA 

This doesn't exist anymore.

> +config PC87312
> +    bool
> +    #select ISA 
> +    select SERIAL
> +    select PARALLEL
> +    select FDC
> +    select IDE_ISA
> +
> +config PIIX4
> +    bool
> +    #select ISA 
> +    depends on PCI
> +
> +config VT82C686
> +    bool
> +    #select ISA 
> +    depends on PCI
> +
> +config LPC_ICH9
> +    bool
> +    #select ISA 
> +    depends on PCI 
> +    select APM

"select ISA" is right for this file.

Paolo