From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDuc2-0001H4-Lj
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 07:05:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDubw-00039z-Qi
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 07:05:34 -0400
Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:41064)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VDubw-00039v-Lr
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 07:05:28 -0400
Received: by mail-qc0-f180.google.com with SMTP id l13so1393350qcy.25
	for <qemu-devel@nongnu.org>; Mon, 26 Aug 2013 04:05:28 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <521B3674.70203@redhat.com>
Date: Mon, 26 Aug 2013 13:05:24 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377471536-12423-1-git-send-email-akoskovacs@gmx.com>
	<1377471536-12423-40-git-send-email-akoskovacs@gmx.com>
In-Reply-To: <1377471536-12423-40-git-send-email-akoskovacs@gmx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 39/47] hw/sd/Kconfig: Add Kconfig file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?w4Frb3MgS292w6Fjcw==?= <akoskovacs@gmx.com>
Cc: qemu-devel@nongnu.org

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <akoskovacs@gmx.com>
> ---
>  hw/sd/Kconfig |   23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 hw/sd/Kconfig
> 
> diff --git a/hw/sd/Kconfig b/hw/sd/Kconfig
> new file mode 100644
> index 0000000..eaef4f7
> --- /dev/null
> +++ b/hw/sd/Kconfig
> @@ -0,0 +1,23 @@
> +config SD
> +    bool
> +
> +config PL181
> +    bool
> +    select SD

"select SD" is right ("library" code).

> +config SSI_SD
> +    bool
> +    select SD
> +    select SSI

But this needs to be "depends on".  In general, you'll usually have
"select SSI" inside hw/ssi, "select ISA" inside hw/isa, "select PCI"
inside hw/pci-host, etc.

Paolo

> +config SDHCI
> +    bool
> +    select SD
> +
> +config MILKYMIST
> +    bool
> +    select SD
> +
> +config PXA2XX
> +    bool
> +    select SD
>