qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Ákos Kovács" <akoskovacs@gmx.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 46/47] configure: Generate Kconfig.targets with --target-list
Date: Mon, 26 Aug 2013 13:14:19 +0200	[thread overview]
Message-ID: <521B388B.9070806@redhat.com> (raw)
In-Reply-To: <1377471536-12423-47-git-send-email-akoskovacs@gmx.com>

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <akoskovacs@gmx.com>
> ---
>  configure |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/configure b/configure
> index 18fa608..353c0cb 100755
> --- a/configure
> +++ b/configure
> @@ -4288,6 +4288,7 @@ case "$target_name" in
>    ;;
>    sparc64)
>      TARGET_BASE_ARCH=sparc
> +    kconfig_subdirs="$kconfig_subdirs sparc64"
>    ;;
>    sparc32plus)
>      TARGET_ARCH=sparc64
> @@ -4311,6 +4312,7 @@ if [ "$TARGET_BASE_ARCH" = "" ]; then
>    TARGET_BASE_ARCH=$TARGET_ARCH
>  fi
>  
> +kconfig_subdirs="$kconfig_subdirs $TARGET_BASE_ARCH"
>  symlink "$source_path/Makefile.target" "$target_dir/Makefile"
>  
>  upper() {
> @@ -4494,6 +4496,15 @@ echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak
>  
>  done # for target in $targets
>  
> +# Generate Kconfig.targets
> +kconfig_targets="Kconfig.targets"
> +kconfig_subdirs=$(echo $kconfig_subdirs | tr ' ' '\n' | sort -u | tr '\n' ' ')
> +echo "# Automatically generated by configure - do not modify" > $kconfig_targets
> +
> +for i in $kconfig_subdirs ; do
> +  echo "source \"hw/$i/Kconfig\"" >> $kconfig_targets
> +done
> +
>  if [ "$pixman" = "internal" ]; then
>    echo "config-host.h: subdir-pixman" >> $config_host_mak
>  fi
> 

There is one issue that we have not solved yet here (pointed out by
Peter Maydell on IRC).  Right now, the presence of a file in
default-configs/ is used to check if a target name is correct.  We need
to figure out a different way to do the same thing.

This needs to cover both softmmu and user targets.  For softmmu, perhaps
there should be a hw/boards/ directory with a subdirectory for each
target.  "source hw/i386/Kconfig" (for Kconfig) or "obj-y += ../i386/"
can be used to recurse back to a common directory from there.

For linux-user, the problem is that we don't have anything to configure
with Kconfig---so no reason to have a Kconfig file or a directory
structure with one directory per target.

Paolo

  reply	other threads:[~2013-08-26 11:14 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-25 22:58 [Qemu-devel] [RFC PATCH 00/47] Describing patchset Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 01/47] rules.mak: New logical functions Ákos Kovács
2013-09-13 13:43   ` Peter Maydell
2013-09-13 14:55     ` Paolo Bonzini
2013-09-13 15:02       ` Peter Maydell
2013-09-13 15:12         ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 02/47] Makefile.target: CONFIG_NO_* variables removed Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 03/47] default-configs/: CONFIG_GDBSTUB_XML removed Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 04/47] scripts/kconfig: kconfig-frontends submodule added Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 05/47] Makefile: Clone kconfig git submodule in Makefile Ákos Kovács
2013-08-26  2:33   ` Andreas Färber
2013-08-25 22:58 ` [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER Ákos Kovács
2013-08-26 14:41   ` Richard Henderson
2013-08-26 16:59     ` Paolo Bonzini
2013-08-26 17:30       ` Richard Henderson
2013-08-26 18:44         ` Lluís Vilanova
2013-08-26 19:47           ` Peter Maydell
2013-08-26 22:44             ` Paolo Bonzini
2013-08-26 22:33         ` Paolo Bonzini
2013-08-26 22:49           ` Richard Henderson
2013-08-26 23:17           ` Peter Maydell
2013-08-27  6:59             ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 07/47] hw/arm/Makefile.objs: CONFIG_* created for each board Ákos Kovács
2013-08-25 23:57   ` Max Filippov
2013-08-26 10:42   ` Peter Maydell
2013-08-25 22:58 ` [Qemu-devel] [PATCH 09/47] hw/m68k/Makefile.objs: Conditionally build boards Ákos Kovács
2013-08-26  0:09   ` Max Filippov
2013-08-25 22:58 ` [Qemu-devel] [PATCH 10/47] hw/microblaze/Makefile.objs: Create configs for petalogix boards Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 11/47] hw/mips/Makefile.objs: Create CONFIG_* for mips boards Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 12/47] hw/ppc/Makefile.objs: Build all boards conditinally Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 13/47] hw/sh4/Makefile.objs: Build sh4 boards conditionally Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 14/47] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 15/47] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 16/47] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_lx60 conditionally Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 17/47] hw/9pfs/Kconfig: Add 9pfs Kconfig Ákos Kovács
2013-08-26 10:39   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 18/47] hw/arm/Kconfig: Add ARM Kconfig Ákos Kovács
2013-08-26 10:38   ` Peter Maydell
2013-08-26 11:09   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 19/47] hw/audio/Kconfig: Add audio Kconfig Ákos Kovács
2013-08-26 10:41   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 20/47] hw/block/Kconfig: Add Kconfig file Ákos Kovács
2013-08-26 10:43   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 21/47] hw/char/Kconfig: " Ákos Kovács
2013-08-26 10:43   ` Paolo Bonzini
2013-08-26 17:15     ` Andreas Färber
2013-08-26 22:40       ` Paolo Bonzini
2013-09-13 14:00         ` Andreas Färber
2013-09-13 14:49           ` Paolo Bonzini
2013-09-15 10:43             ` Alberto Garcia
2013-08-25 22:58 ` [Qemu-devel] [PATCH 22/47] hw/core/Kconfig: " Ákos Kovács
2013-08-26 10:45   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 23/47] hw/cpu/Kconfig: " Ákos Kovács
2013-08-26 17:03   ` Andreas Färber
2013-08-25 22:58 ` [Qemu-devel] [PATCH 24/47] hw/display/Kconfig: " Ákos Kovács
2013-08-26 10:49   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 25/47] hw/dma/Kconfig: " Ákos Kovács
2013-08-26 10:49   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 26/47] hw/gpio/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 27/47] hw/i2c/Kconfig: " Ákos Kovács
2013-08-26 10:50   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 28/47] hw/ide/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 29/47] hw/input/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 30/47] hw/intc/Kconfig: " Ákos Kovács
2013-08-26 10:53   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 31/47] hw/isa/Kconfig: " Ákos Kovács
2013-08-26 11:03   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 32/47] hw/misc/Kconfig: " Ákos Kovács
2013-08-26 11:00   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 33/47] hw/net/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 34/47] hw/nvram/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 35/47] hw/pci/Kconfig: " Ákos Kovács
2013-08-26 11:01   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 36/47] hw/pci-bridge/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 37/47] hw/pci-host/Kconfig: " Ákos Kovács
2013-08-26 11:02   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 38/47] hw/scsi/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 39/47] hw/sd/Kconfig: " Ákos Kovács
2013-08-26 11:05   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 40/47] hw/ssi/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 41/47] hw/timer/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 42/47] hw/tpm/Kconfig: " Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 43/47] hw/usb/Kconfig: " Ákos Kovács
2013-08-26 11:06   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 44/47] hw/watchdog/Kconfig: " Ákos Kovács
2013-08-26 11:06   ` Paolo Bonzini
2013-08-25 22:58 ` [Qemu-devel] [PATCH 45/47] hw/Kconfig: Add the main Kconfig for hw/ Ákos Kovács
2013-08-25 22:58 ` [Qemu-devel] [PATCH 46/47] configure: Generate Kconfig.targets with --target-list Ákos Kovács
2013-08-26 11:14   ` Paolo Bonzini [this message]
2013-08-25 22:58 ` [Qemu-devel] [PATCH 47/47] Kconfig: Main kconfig file added Ákos Kovács
2013-08-26  7:35 ` [Qemu-devel] [RFC PATCH 00/47] Describing patchset Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521B388B.9070806@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=akoskovacs@gmx.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).