From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/5] qcow2: Check allocations in qcow2_check
Date: Mon, 26 Aug 2013 15:15:10 +0200 [thread overview]
Message-ID: <521B54DE.7090202@redhat.com> (raw)
In-Reply-To: <1377522260-16676-5-git-send-email-mreitz@redhat.com>
Hi,
On Mon, Aug 26, 2013 at 15:04 +0200, Max Reitz wrote:
> Adds a new function checking for overlapping cluster allocations.
> Furthermore, qcow2_check now marks the image as consistent if no
> corruptions have been found.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Such overlappings are often (if not always) found by the refcount checks
as well. By increasing the refcount of the clusters affected and
therefore enforcing COW, the collision is basically fixed as well
without requiring this new function.
Thus I'm not sure whether this new function is actually necessary since
the existing refcount check seems to cover all its functionality already.
But, well, I thought it couldn't hurt proposing this function at least. ;-)
Kind regards,
Max
next prev parent reply other threads:[~2013-08-26 13:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 13:04 [Qemu-devel] [PATCH 0/5] qcow2: Add metadata overlap checks Max Reitz
2013-08-26 13:04 ` [Qemu-devel] [PATCH 1/5] qcow2: Add corrupt bit Max Reitz
2013-08-27 9:54 ` Kevin Wolf
2013-08-27 10:00 ` Max Reitz
2013-08-26 13:04 ` [Qemu-devel] [PATCH 2/5] qcow2: Metadata overlap checks Max Reitz
2013-08-27 10:17 ` Kevin Wolf
2013-08-27 11:06 ` Max Reitz
2013-08-27 11:16 ` Kevin Wolf
2013-08-26 13:04 ` [Qemu-devel] [PATCH 3/5] qcow2: Employ metadata " Max Reitz
2013-08-27 11:32 ` Kevin Wolf
2013-08-27 11:41 ` Max Reitz
2013-08-27 11:51 ` Kevin Wolf
2013-08-26 13:04 ` [Qemu-devel] [PATCH 4/5] qcow2: Check allocations in qcow2_check Max Reitz
2013-08-26 13:15 ` Max Reitz [this message]
2013-08-27 12:23 ` Kevin Wolf
2013-08-26 13:04 ` [Qemu-devel] [PATCH 5/5] qemu-iotests: Overlapping cluster allocations Max Reitz
2013-08-27 12:37 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2013-08-26 10:18 [Qemu-devel] [PATCH 0/5] qcow2: Add metadata overlap checks Max Reitz
2013-08-26 10:18 ` [Qemu-devel] [PATCH 4/5] qcow2: Check allocations in qcow2_check Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521B54DE.7090202@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).