From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDx5E-0007fR-69 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 09:43:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VDx58-0007Yg-Um for qemu-devel@nongnu.org; Mon, 26 Aug 2013 09:43:52 -0400 Message-ID: <521B5B87.30901@redhat.com> Date: Mon, 26 Aug 2013 15:43:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377249797-12623-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1377249797-12623-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr-vscsi: Report error on unsupported MAD requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf Il 23/08/2013 11:23, Alexey Kardashevskiy ha scritto: > The existing driver just dropped unsupported requests. This adds error > responses to those unhandled requests. > > Signed-off-by: Alexey Kardashevskiy > --- > hw/scsi/spapr_vscsi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c > index cc35b1b..9259d7e 100644 > --- a/hw/scsi/spapr_vscsi.c > +++ b/hw/scsi/spapr_vscsi.c > @@ -957,24 +957,24 @@ static int vscsi_handle_mad_req(VSCSIState *s, vscsi_req *req) > break; > case VIOSRP_ERROR_LOG_TYPE: > fprintf(stderr, "Unsupported ERROR LOG MAD IU\n"); Please use error_report... > - mad->error_log.common.status = cpu_to_be16(1); > - vscsi_send_iu(s, req, sizeof(mad->error_log), VIOSRP_MAD_FORMAT); > break; > case VIOSRP_ADAPTER_INFO_TYPE: > vscsi_send_adapter_info(s, req); > - break; > + return 1; > case VIOSRP_HOST_CONFIG_TYPE: > - mad->host_config.common.status = cpu_to_be16(1); > - vscsi_send_iu(s, req, sizeof(mad->host_config), VIOSRP_MAD_FORMAT); > + fprintf(stderr, "Unsupported HOST CONFIG TYPE MAD IU\n"); ... especially in this new fprintf... > break; > case VIOSRP_CAPABILITIES_TYPE: > vscsi_send_capabilities(s, req); > - break; > + return 1; > default: > fprintf(stderr, "VSCSI: Unknown MAD type %02x\n", > be32_to_cpu(mad->empty_iu.common.type)); ... and here too, please. Thanks, Paolo > } > > + mad->empty_iu.common.status = cpu_to_be16(VIOSRP_MAD_NOT_SUPPORTED); > + vscsi_send_iu(s, req, mad->empty_iu.common.length, VIOSRP_MAD_FORMAT); > + > return 1; > } > >