From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] curl: qemu_bh_new() can never return NULL
Date: Mon, 26 Aug 2013 15:48:28 +0200 [thread overview]
Message-ID: <521B5CAC.8090201@redhat.com> (raw)
In-Reply-To: <1377517130-12343-1-git-send-email-stefanha@redhat.com>
Il 26/08/2013 13:38, Stefan Hajnoczi ha scritto:
> Drop error code path which cannot be taken since qemu_bh_new() does not
> return NULL.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> block/curl.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/block/curl.c b/block/curl.c
> index e566855..ca2cedc 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -572,12 +572,6 @@ static BlockDriverAIOCB *curl_aio_readv(BlockDriverState *bs,
> acb->nb_sectors = nb_sectors;
>
> acb->bh = qemu_bh_new(curl_readv_bh_cb, acb);
> -
> - if (!acb->bh) {
> - DPRINTF("CURL: qemu_bh_new failed\n");
> - return NULL;
> - }
> -
> qemu_bh_schedule(acb->bh);
> return &acb->common;
> }
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2013-08-26 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 11:38 [Qemu-devel] [PATCH] curl: qemu_bh_new() can never return NULL Stefan Hajnoczi
2013-08-26 13:48 ` Paolo Bonzini [this message]
2013-09-01 15:12 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521B5CAC.8090201@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).