From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE08n-0000Bw-31 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 12:59:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VE08h-00016V-7T for qemu-devel@nongnu.org; Mon, 26 Aug 2013 12:59:45 -0400 Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:50764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE08h-00016Q-1N for qemu-devel@nongnu.org; Mon, 26 Aug 2013 12:59:39 -0400 Received: by mail-we0-f182.google.com with SMTP id q59so3013760wes.27 for ; Mon, 26 Aug 2013 09:59:38 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <521B8975.9020806@redhat.com> Date: Mon, 26 Aug 2013 18:59:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377471536-12423-1-git-send-email-akoskovacs@gmx.com> <1377471536-12423-7-git-send-email-akoskovacs@gmx.com> <521B6909.9020708@twiddle.net> In-Reply-To: <521B6909.9020708@twiddle.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: =?UTF-8?B?w4Frb3MgS292w6Fjcw==?= , qemu-devel@nongnu.org Il 26/08/2013 16:41, Richard Henderson ha scritto: > On 08/25/2013 03:58 PM, Ákos Kovács wrote: >> Set CONFIG_CLIPPER as default for default-configs/alpha-softmmu.mak >> >> Signed-off-by: Ákos Kovács >> --- >> default-configs/alpha-softmmu.mak | 2 ++ >> hw/alpha/Makefile.objs | 2 +- >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/default-configs/alpha-softmmu.mak b/default-configs/alpha-softmmu.mak >> index bc07600..1e8bbff 100644 >> --- a/default-configs/alpha-softmmu.mak >> +++ b/default-configs/alpha-softmmu.mak >> @@ -15,3 +15,5 @@ CONFIG_IDE_CMD646=y >> CONFIG_I8259=y >> CONFIG_MC146818RTC=y >> CONFIG_ISA_TESTDEV=y >> + >> +CONFIG_CLIPPER=y >> diff --git a/hw/alpha/Makefile.objs b/hw/alpha/Makefile.objs >> index 5c74275..0a6ade5 100644 >> --- a/hw/alpha/Makefile.objs >> +++ b/hw/alpha/Makefile.objs >> @@ -1 +1 @@ >> -obj-y += dp264.o pci.o typhoon.o >> +obj-$(CONFIG_CLIPPER) += dp264.o pci.o typhoon.o >> > > I don't understand the point of this. There is one alpha emulation; > if you disable it you're left with a program that's not useful. So > why the configuration for it at all? I think this was just for consistency with other targets. Either this patch can be left out completely, or the symbol can be made default on and unchangeable by the user. Paolo