From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org, Paul Mackerras <paulus@samba.org>,
qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] spapr: support CPU hotplug
Date: Tue, 27 Aug 2013 09:02:08 +0200 [thread overview]
Message-ID: <521C4EF0.9090405@redhat.com> (raw)
In-Reply-To: <521C4942.9060402@ozlabs.ru>
Il 27/08/2013 08:37, Alexey Kardashevskiy ha scritto:
>>> So this is here to make sure we don't accidentally get out of halted state by an interrupt on that vcpu. Could you please somehow make that part obvious? Either by adding a comment or by only explicitly masking DEC and EE and a comment :).
>>>
>>>> + cs->exit_request = 1;
>>>
>>> This should probably be qemu_cpu_kick_self().
>>
>> Uh, no, I don't think so. This is there purely to make sure we exit
>> the inner loop, and actually test cpu_can_run() which will test
>> halted. AFAICT qemu_cpu_kick_self() won't do anything similar.
>
> rtas_stop_self() eventually returns to kvm_cpu_exec() which calls
> qemu_cpu_kick_self() and resets cs->exit_request before return so I do not
> really see the difference in behaviour. And actually both ways CPU stops in
> exactly the same way. What do I miss?
What about TCG?
Paolo
next prev parent reply other threads:[~2013-08-27 7:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 11:30 [Qemu-devel] [PATCH] spapr: support CPU hotplug Alexey Kardashevskiy
2013-08-26 12:24 ` Alexander Graf
2013-08-26 15:29 ` David Gibson
2013-08-27 6:37 ` Alexey Kardashevskiy
2013-08-27 7:02 ` Paolo Bonzini [this message]
2013-08-27 7:41 ` Alexey Kardashevskiy
2013-08-27 8:54 ` Alexander Graf
2013-08-27 9:03 ` Alexey Kardashevskiy
2013-08-27 9:11 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521C4EF0.9090405@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).