From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEDJ0-00089B-Uj for qemu-devel@nongnu.org; Tue, 27 Aug 2013 03:03:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEDIt-00069M-K4 for qemu-devel@nongnu.org; Tue, 27 Aug 2013 03:03:10 -0400 Sender: Paolo Bonzini Message-ID: <521C4EF0.9090405@redhat.com> Date: Tue, 27 Aug 2013 09:02:08 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377257435-27714-1-git-send-email-aik@ozlabs.ru> <20130826152902.GB9120@voom.fritz.box> <521C4942.9060402@ozlabs.ru> In-Reply-To: <521C4942.9060402@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr: support CPU hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, Paul Mackerras , qemu-ppc@nongnu.org, Alexander Graf , David Gibson Il 27/08/2013 08:37, Alexey Kardashevskiy ha scritto: >>> So this is here to make sure we don't accidentally get out of halted state by an interrupt on that vcpu. Could you please somehow make that part obvious? Either by adding a comment or by only explicitly masking DEC and EE and a comment :). >>> >>>> + cs->exit_request = 1; >>> >>> This should probably be qemu_cpu_kick_self(). >> >> Uh, no, I don't think so. This is there purely to make sure we exit >> the inner loop, and actually test cpu_can_run() which will test >> halted. AFAICT qemu_cpu_kick_self() won't do anything similar. > > rtas_stop_self() eventually returns to kvm_cpu_exec() which calls > qemu_cpu_kick_self() and resets cs->exit_request before return so I do not > really see the difference in behaviour. And actually both ways CPU stops in > exactly the same way. What do I miss? What about TCG? Paolo