From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEOBY-0007pg-2T for qemu-devel@nongnu.org; Tue, 27 Aug 2013 14:40:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEOBS-0003cE-GB for qemu-devel@nongnu.org; Tue, 27 Aug 2013 14:40:12 -0400 Received: from mail-gh0-x230.google.com ([2607:f8b0:4002:c05::230]:55378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEOBS-0003bT-Bg for qemu-devel@nongnu.org; Tue, 27 Aug 2013 14:40:06 -0400 Received: by mail-gh0-f176.google.com with SMTP id z17so1266508ghb.7 for ; Tue, 27 Aug 2013 11:40:05 -0700 (PDT) Sender: Richard Henderson Message-ID: <521CF27A.1070607@twiddle.net> Date: Tue, 27 Aug 2013 11:39:54 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1377619333-16062-1-git-send-email-james.hogan@imgtec.com> In-Reply-To: <1377619333-16062-1-git-send-email-james.hogan@imgtec.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu: Fix cross compilation for mipsel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: James Hogan Cc: Sanjay Lal , Mike Frysinger , qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 08/27/2013 09:02 AM, James Hogan wrote: > The configure script was setting HOST_WORDS_BIGENDIAN for all $cpu = > mips|mips64 when cross compiling, since endianness cannot be detected by > running a test program. This includes little endian MIPS though. It > didn't cause any build errors but does prevent QEMU from working > correctly. Instead, detect the endianness similar to how we do for ARM, > by checking for the __MIPSEB__ builtin processor definition. > > This is from a hunk in the "[PATCH 8/12] KVM/MIPS: Enable KVM/MIPS for > MIPS targets. Add MIPS GIC code to the build" patch by Sanjay Lal [1]. Redundant with Mike Frysinger's more general patch, http://patchwork.ozlabs.org/patch/256001/ r~