From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VEPFz-0005dZ-2s
	for qemu-devel@nongnu.org; Tue, 27 Aug 2013 15:48:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VEPFq-0008L8-MU
	for qemu-devel@nongnu.org; Tue, 27 Aug 2013 15:48:51 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <521D028F.1070505@twiddle.net>
Date: Tue, 27 Aug 2013 12:48:31 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1377622116-37650-1-git-send-email-yongbok.kim@imgtec.com>
In-Reply-To: <1377622116-37650-1-git-send-email-yongbok.kim@imgtec.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address()
 #if 0 build error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yongbok Kim <yongbok.kim@imgtec.com>
Cc: qemu-trivial@nongnu.org, james.hogan@imgtec.com, qemu-devel@nongnu.org, aurelien@aurel32.net

On 08/27/2013 09:48 AM, Yongbok Kim wrote:
>  #if 0
> -    qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n",
> +    qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n",
>              address, rw, access_type, *physical, *prot, ret);
>  #endif

While by itself correct, consider converting this to the trace infrastructure
(with uint64_t instead of hwaddr).

If it's not worth a trace, it's probably not worth keeping at all.


r~