From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VESaj-0000dt-5S for qemu-devel@nongnu.org; Tue, 27 Aug 2013 19:22:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VESab-00027X-Fz for qemu-devel@nongnu.org; Tue, 27 Aug 2013 19:22:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VESab-00027R-8k for qemu-devel@nongnu.org; Tue, 27 Aug 2013 19:22:21 -0400 Message-ID: <521D34AB.5080700@redhat.com> Date: Tue, 27 Aug 2013 17:22:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1376659114-6630-1-git-send-email-armbru@redhat.com> <1376659114-6630-8-git-send-email-armbru@redhat.com> <20130827170444.GA29703@redhat.com> In-Reply-To: <20130827170444.GA29703@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pXbSQoLL0qkuQ1ulgrKnrq20bNSSJKGxn" Subject: Re: [Qemu-devel] [PATCH v2 7/7] smbios: Set system manufacturer, product & version by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, lersek@redhat.com, armbru@redhat.com, ehabkost@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pXbSQoLL0qkuQ1ulgrKnrq20bNSSJKGxn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/27/2013 11:04 AM, Michael S. Tsirkin wrote: > On Fri, Aug 16, 2013 at 03:18:34PM +0200, armbru@redhat.com wrote: >> From: Markus Armbruster >> >> Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs,= >> no version. Best SeaBIOS can do, but we can provide better defaults: >> manufacturer QEMU, product & version taken from QEMUMachine desc and >> name. >> >> Take care to do this only for new machine types, of course. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >=20 > We can do this of course, but why is this better? > It seems to expose new information to the guest > for no reason, we just might come to regret it > later if guests start implementing hacks keying > off the version number. Some guests (cough: some OEM builds of windows) already DO key off of SMBIOS information to determine if they are running in a valid environment. Furthermore, making this change to qemu makes it easier to decouple the strings being presented to guests by default; it's always better to have a situation where changing just qemu works, instead of having to patch both qemu and BIOS in tandem. The choice of whether to present the different information MUST be tied to machine types (we cannot change SMBIOS data without an explicit change to a newer machine type, precisely _because_ there are guests that base their licensing decisions on constancy of BIOS information). But for a new machine type, presenting qemu as the machine type rather than being stuck to a particular SeaBIOS build seems nicer. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pXbSQoLL0qkuQ1ulgrKnrq20bNSSJKGxn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSHTSrAAoJEKeha0olJ0Nqt2IH/A6Omxr97x6oquSwxcH64eOq 9csTvvBuJSoUrSHHRkS5NnklP539kjgjCl/2bFj7qA5D7+LMGuGZqAidzytK5EwW 9gB55kutcCgICZz0idBGavFsSFG2NXfUkA4VSi7sC52NOcBo0rqJndBsANyeAUcv AOg9UfDHXR8y+Lk+6X8r7NJF4P31sfLTG0tFFkbE0Phxd1Pnv9rChdtDbAoUflZR WRmWc3B+WeCID0esg0TlvkvJ9tilJ/WycDYo05QA8llscJPnevmXtvoftLZiWEAg SZ1qf/lDuckmQ28hgPzD0YbYpNNcRxj3KcXKDNkAlgMVJfkYepH4LS/xGAvLMFQ= =26uM -----END PGP SIGNATURE----- --pXbSQoLL0qkuQ1ulgrKnrq20bNSSJKGxn--