From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEU3C-0004SK-PM for qemu-devel@nongnu.org; Tue, 27 Aug 2013 20:56:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEU35-0002XL-GG for qemu-devel@nongnu.org; Tue, 27 Aug 2013 20:55:58 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:42382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEU35-0002XD-9M for qemu-devel@nongnu.org; Tue, 27 Aug 2013 20:55:51 -0400 Received: by mail-pd0-f174.google.com with SMTP id y13so5524667pdi.5 for ; Tue, 27 Aug 2013 17:55:49 -0700 (PDT) Message-ID: <521D4A8E.8070908@ozlabs.ru> Date: Wed, 28 Aug 2013 10:55:42 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1375865493-19143-1-git-send-email-aik@ozlabs.ru> <1375865493-19143-2-git-send-email-aik@ozlabs.ru> <20130819073550.GE17937@redhat.com> <5211CCC4.3010606@ozlabs.ru> <20130819075434.GA18579@redhat.com> <5211D2D9.5050101@ozlabs.ru> <20130819090128.GA20139@redhat.com> <5216E530.4060007@ozlabs.ru> <6CCA8220-0125-4CB5-A54E-9648D8B409D2@suse.de> <20130827102647.GA24655@redhat.com> <1377599548.3819.133.camel@pasglop> In-Reply-To: <1377599548.3819.133.camel@pasglop> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] kvm irqfd: support msimessage to irq translation in PHB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: Anthony Liguori , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Alexander Graf , Alex Williamson , qemu-ppc@nongnu.org, Paolo Bonzini , Paul Mackerras On 08/27/2013 08:32 PM, Benjamin Herrenschmidt wrote: > On Tue, 2013-08-27 at 13:26 +0300, Michael S. Tsirkin wrote: >> e would end up with something like >>> >>> diff --git a/kvm-all.c b/kvm-all.c >>> index 716860f..ca3251e 100644 >>> --- a/kvm-all.c >>> +++ b/kvm-all.c >>> @@ -1190,6 +1190,10 @@ int kvm_irqchip_add_msi_route(KVMState *s, MSIMessage msg) >>> struct kvm_irq_routing_entry kroute = {}; >>> int virq; >>> >>> + if (kvm_gsi_routing_linear()) { >>> + return msi.data & 0xffff; >>> + } >>> + > > I haven't followed the whole discussion, Alexey, is this the per-host > bridge source number or the global XIRR (XICS interrupt number) ? When I started this topic, that was per bridge and this is why I changed it to be global and eventually this spapr-MSIX fix reached agraf/ppc-next (happened last week) so the fix above should just work now. > Because in the latter case, it can be up to 24 bits... (And yes, MSI > data is limited to 16). Yes, this is the main limitation here. > However maybe we can decide arbitrarily that under qemu/kvm we only > support 16-bit XIRRs (it's fine, from a PAPR perspective at least if it > keep things simpler). I'll keep 0xffff then as everybody is happy with this. -- Alexey