From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEXJ2-0003bC-Np for qemu-devel@nongnu.org; Wed, 28 Aug 2013 00:24:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEXIt-0001BE-Pd for qemu-devel@nongnu.org; Wed, 28 Aug 2013 00:24:32 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:36406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEXIt-0001B4-6m for qemu-devel@nongnu.org; Wed, 28 Aug 2013 00:24:23 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 28 Aug 2013 14:13:44 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id DE1E63578052 for ; Wed, 28 Aug 2013 14:24:16 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7S484Gh25362584 for ; Wed, 28 Aug 2013 14:08:11 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7S4O8C4031618 for ; Wed, 28 Aug 2013 14:24:09 +1000 Message-ID: <521D7B1B.9020504@linux.vnet.ibm.com> Date: Wed, 28 Aug 2013 12:22:51 +0800 From: Lei Li MIME-Version: 1.0 References: <1377069536-12658-1-git-send-email-lilei@linux.vnet.ibm.com> <1377069536-12658-12-git-send-email-lilei@linux.vnet.ibm.com> <5214D7E0.4000008@redhat.com> In-Reply-To: <5214D7E0.4000008@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/18] migration: introduce capability localhost List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aarcange@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, Anthony Liguori , lagarcia@br.ibm.com, pbonzini@redhat.com, rcj@linux.vnet.ibm.com On 08/21/2013 11:08 PM, Eric Blake wrote: > On 08/21/2013 01:18 AM, Lei Li wrote: >> Introduce migration capability localhost. >> >> Signed-off-by: Lei Li >> --- >> include/migration/migration.h | 3 +++ >> migration.c | 12 ++++++++++++ >> qapi-schema.json | 8 +++++++- >> 3 files changed, 22 insertions(+), 1 deletions(-) >> >> +++ b/qapi-schema.json >> @@ -629,10 +629,16 @@ >> # @auto-converge: If enabled, QEMU will automatically throttle down the guest >> # to speed up convergence of RAM migration. (since 1.6) >> # >> +# @localhost: If enabled, QEMU will support localhost migration. This feature >> +# allows live upgrade of a running QEMU instance by doing localhost >> +# migration with page flipping. It requires the source and destination >> +# are both on localhost. Disabled by default. (since 1.7) > Logically, ALL new migration parameters should be disabled by default, > as that provides the sanest back-compat setting. Your last sentence is > therefore redundant. But this is certainly a much nicer implementation > than your v1 attempt. > > If I understand correctly, attempts to use 'local:...' are rejected > unless you first use migrate-set-capabilities to turn on localhost > migration support. Hi Eric, The attempt to use 'local' will not be rejected if we don't use migrate-set-capabilities first. Because the destination QEMU process have no idea whether this capability is set in MigrationState. It will just lead to a failure of migration connection. According to Paolo's new suggestion in patch set 17/18, IIUIC, it will get rid of this 'local' prefix, just use 'unix' protocol URI. In this case, the incoming part for localhost migration will only be called if the source support it by checking if the pipe can be got via SCM_RIGHTS. > -- Lei