From: James Hogan <james.hogan@imgtec.com>
To: Richard Henderson <rth@twiddle.net>
Cc: Yongbok Kim <yongbok.kim@imgtec.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error
Date: Wed, 28 Aug 2013 09:28:11 +0100 [thread overview]
Message-ID: <521DB49B.5060708@imgtec.com> (raw)
In-Reply-To: <521D028F.1070505@twiddle.net>
On 27/08/13 20:48, Richard Henderson wrote:
> On 08/27/2013 09:48 AM, Yongbok Kim wrote:
>> #if 0
>> - qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n",
>> + qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n",
>> address, rw, access_type, *physical, *prot, ret);
>> #endif
>
> While by itself correct, consider converting this to the trace infrastructure
> (with uint64_t instead of hwaddr).
>
> If it's not worth a trace, it's probably not worth keeping at all.
True. I suspect it isn't worth a trace (I just happened to be modifying
that function so tried it out to test my changes - and anybody doing
that can easily add a temporary qemu_log/fprintf message themselves).
Cheers
James
next prev parent reply other threads:[~2013-08-28 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 16:48 [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error Yongbok Kim
2013-08-27 19:48 ` Richard Henderson
2013-08-28 8:28 ` James Hogan [this message]
2013-08-28 21:03 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521DB49B.5060708@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=yongbok.kim@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).