From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52906)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VEd5M-000311-Hw
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 06:34:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VEd5F-0004Su-46
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 06:34:48 -0400
Message-ID: <521DD236.1070507@suse.de>
Date: Wed, 28 Aug 2013 12:34:30 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <520CEA00.2020404@suse.de>
	<1376885192-31651-1-git-send-email-aik@ozlabs.ru>
	<FCFB1E44-E2F6-4D5F-A8B5-45A2AAEA1F19@suse.de>
	<521B66ED.1010905@suse.de> <521DD17A.5050308@ozlabs.ru>
In-Reply-To: <521DD17A.5050308@ozlabs.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH v4] powerpc: add PVR mask support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Paul Mackerras <paulus@samba.org>

Am 28.08.2013 12:31, schrieb Alexey Kardashevskiy:
> On 08/27/2013 12:32 AM, Andreas F=C3=A4rber wrote:
>> Am 26.08.2013 15:04, schrieb Alexander Graf:
>>>
>>> On 19.08.2013, at 06:06, Alexey Kardashevskiy wrote:
>>>
>>>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init=
.c
>>>> index 13b290c..dfe398d 100644
>>>> --- a/target-ppc/translate_init.c
>>>> +++ b/target-ppc/translate_init.c
>>>> @@ -3104,7 +3104,6 @@ static int check_pow_hid0_74xx (CPUPPCState *e=
nv)
>>>>     glue(glue(ppc_, _name), _cpu_family_type_info) =3D {            =
          \
>>>>         .name =3D stringify(_name) "-family-" TYPE_POWERPC_CPU,     =
          \
>>>>         .parent =3D TYPE_POWERPC_CPU,                               =
          \
>>>> -        .abstract =3D true,                                        =
           \
>>>>         .class_init =3D glue(glue(ppc_, _name), _cpu_family_class_in=
it),      \
>>>>     };                                                              =
        \
>>>>                                                                     =
        \
>>
>> This should no longer be necessary (once the fuzzy search is implement=
ed
>> in KVM host type registration code path) and trivially solves the -cpu=
 ?
>> / QMP aspect Alex mentioned above.
>=20
>=20
> I do not really understand this part. Will we still need/want
> .abstract=3D=3Dtrue?

No, we don't need/want it since the host CPU type is non-abstract
already and can inherit from abstract types without problem.

Andreas

> I'll post yet another version of my patch in next 3
> minutes, there I skip PPC CPU classes which parent is TYPE_POWERPC_CPU,
> pretty trivial already :)

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg