From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEeEF-0007x0-52 for qemu-devel@nongnu.org; Wed, 28 Aug 2013 07:48:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEeE9-0002GE-55 for qemu-devel@nongnu.org; Wed, 28 Aug 2013 07:48:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEeE8-0002Fw-Ss for qemu-devel@nongnu.org; Wed, 28 Aug 2013 07:47:57 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7SBluih011637 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Aug 2013 07:47:56 -0400 Message-ID: <521DE36A.2030209@redhat.com> Date: Wed, 28 Aug 2013 13:47:54 +0200 From: Max Reitz MIME-Version: 1.0 References: <1377677336-15804-1-git-send-email-mreitz@redhat.com> <1377677336-15804-4-git-send-email-mreitz@redhat.com> <20130828114041.GF2743@dhcp-200-207.str.redhat.com> In-Reply-To: <20130828114041.GF2743@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-iotest: qcow2 image option amendment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi Am 28.08.2013 13:40, schrieb Kevin Wolf: > Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: >> Add tests for qemu-img amend on qcow2 image files. >> >> Signed-off-by: Max Reitz >> --- >> This test is numbered 061 for not interfering with my "metadata overla= p >> checks" series (although I will have to adapt my code to those new che= cks >> anyway when/if they are included in master). >> --- >> tests/qemu-iotests/061 | 121 +++++++++++++++++++ >> tests/qemu-iotests/061.out | 289 +++++++++++++++++++++++++++++++++++= ++++++++++ >> tests/qemu-iotests/group | 1 + >> 3 files changed, 411 insertions(+) >> create mode 100755 tests/qemu-iotests/061 >> create mode 100644 tests/qemu-iotests/061.out > The existing cases look good. I would add some _check_test_img calls > after each amendment, and perhaps include a few cases with non-standard > cluster_size etc. during image creation (which would show that your TOD= O > isn't addressed yet). > > Kevin > Ah, right, because it won't be 0 but DEFAULT_CLUSTER_SIZE then=85 Hm. So,= =20 generally, right now I can just check whether the value differs and is=20 not DEFAULT_CLUSTER_SIZE (which would obviously silently ignore the flag=20 when cluster_size=3D$DEFAULT_CLUSTER_SIZE was given)? Max