From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEelM-0000yk-7d for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:22:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEelH-0004yq-7R for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:22:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEelG-0004ym-Up for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:22:11 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7SCMAWS002112 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Aug 2013 08:22:10 -0400 Message-ID: <521DEB71.1030507@redhat.com> Date: Wed, 28 Aug 2013 06:22:09 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377677336-15804-1-git-send-email-mreitz@redhat.com> <1377677336-15804-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1377677336-15804-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iKv7QHCPD8hHq1vrLrRnluOb9mvuLuofD" Subject: Re: [Qemu-devel] [PATCH 1/3] block: Image file option amendment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iKv7QHCPD8hHq1vrLrRnluOb9mvuLuofD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/28/2013 02:08 AM, Max Reitz wrote: > This patch adds the "amend" option to qemu-img which allows changing > image options on existing image files. It also adds the generic bdrv > implementation which is basically just a wrapper for the image format > specific function. >=20 > + > +@item amend [-f @var{fmt}] -o @var{options} @var{filename} > + > +Amends the image format specific @var{options} for the image file > +@var{filename}. Only the format @code{qcow2} supports this. The flattening of implicit zero clusters into explicit may take a significant amount of time; please consider adding support for -p (progress meter) as part of this addition. (I'm already bothered by the fact that the 'commit' operation lacks a progress meter; and even 'check' might have cases where it could be long-running) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --iKv7QHCPD8hHq1vrLrRnluOb9mvuLuofD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSHetxAAoJEKeha0olJ0NqwzkH/17Hu/px355/FVn05F/0LxjB HhVh3iwbJcMcUdobF8QcfMjmkmlmeaRLEy4DP3iRK0tAt37Nazhg+NQJQN/4Xn2Q D+yuJ5CDLb6KWzd678OSydR7YPKchB/TStSYGcilsicO6Cos2OtrJ6Rvtg8W5Jgf xKRaeoIeQST0vOfdaHBc76qoZuipw+wj+Zj0W+CCVEBKUUlXuGnQty0ZHug/szlf yx4FU6ddxNLwkF9Hc3ljIug7v6zf23+FaTadhCJ/DThs0nDCsr7Lb9dq0g/RGl4/ FD21srVQzJB7gnBS01HVDp1p/DPLMBTaR9koWRAmSQrvEBRV091te1jaZ8szXgY= =oo87 -----END PGP SIGNATURE----- --iKv7QHCPD8hHq1vrLrRnluOb9mvuLuofD--