Re: [Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

On 08/12/2013 10:31 PM, Dong Xu Wang wrote:
> qemu_opts_print has no user now, so can re-write the function safely.
> 
> qemu_opts_print is used while using "qemu-img create", it
> produces the same output as previous code.
> 
> The behavior of this function has changed:
> 
> 1. Print every possible option, whether a value has been set or not.
> 2. Option descriptors may provide a default value.
> 3. Print to stdout instead of stderr.
> 
> Previously the behavior was to print every option that has been set.
> Options that have not been set would be skipped.
> 
> v17->v18:
> 1) print opt->value.uint directly while type is QEMU_OPT_SIZE. 

When making a change to a previously-reviewed patch, unrelated to the
reviewer's comments...

> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>

...it is probably better to drop the earlier Reviewed-by: to make sure
that the change gets properly reviewed.  Keeping a Reviewed-by makes
sense only when carrying a patch with no changes, or when the set of
changes made are trivial in nature (such as whitespace cleanups) or
explicitly mentioned as the changes desired by the reviewer.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]