From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEfGE-0008Kb-7r for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:54:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEfG9-0006oK-BE for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:54:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEfG9-0006o1-2v for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:54:05 -0400 Message-ID: <521DF2E6.7080109@redhat.com> Date: Wed, 28 Aug 2013 06:53:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1376368326-7433-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1376368326-7433-2-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1376368326-7433-2-git-send-email-wdongxu@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ERVlT9jgSB7pDmgtkIUKF80t8hVKiwNVf" Subject: Re: [Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: kwolf@redhat.com, wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ERVlT9jgSB7pDmgtkIUKF80t8hVKiwNVf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/12/2013 10:31 PM, Dong Xu Wang wrote: > qemu_opts_print has no user now, so can re-write the function safely. >=20 > qemu_opts_print is used while using "qemu-img create", it > produces the same output as previous code. >=20 > The behavior of this function has changed: >=20 > 1. Print every possible option, whether a value has been set or not. > 2. Option descriptors may provide a default value. > 3. Print to stdout instead of stderr. >=20 > Previously the behavior was to print every option that has been set. > Options that have not been set would be skipped. >=20 > v17->v18: > 1) print opt->value.uint directly while type is QEMU_OPT_SIZE.=20 When making a change to a previously-reviewed patch, unrelated to the reviewer's comments... >=20 > Reviewed-by: Eric Blake > Signed-off-by: Dong Xu Wang =2E..it is probably better to drop the earlier Reviewed-by: to make sure that the change gets properly reviewed. Keeping a Reviewed-by makes sense only when carrying a patch with no changes, or when the set of changes made are trivial in nature (such as whitespace cleanups) or explicitly mentioned as the changes desired by the reviewer. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ERVlT9jgSB7pDmgtkIUKF80t8hVKiwNVf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSHfLmAAoJEKeha0olJ0Nq+mAH/3qoMEUigSgG7+/MCWjxfOgv r99ZjQrT7vzZ75XAw0C7cac6d/3rpxuFB8GFa+FVhSexwHX5CbSHTavielIsFHJf HTVFyWN52nyPUWWf1LuLcAygF6/3W6jLTAYOIkUHt666CGLCrvhzyEeEZt9IuonJ Y5DZOC/pTbu/N4PLos5oqjhQMK029Z4fPf9m1N2zCsPDBc6fDVzGUbMFZe22GKNx Or+Lqn31+ZVxKOh0QKATwiRSK09Pe9d8uFKUrS7Z0kMzownSB7iSBBdSUtLPrjhF wVtLpmb5bnTLLZLC6fTgz/Y/kongYySM31P6wDye4jhjYiBt336KCPq8F/LKO+g= =lz+i -----END PGP SIGNATURE----- --ERVlT9jgSB7pDmgtkIUKF80t8hVKiwNVf--