From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEfJU-0002ed-JN for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEfJP-0007du-MR for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:57:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEfJP-0007df-Dx for qemu-devel@nongnu.org; Wed, 28 Aug 2013 08:57:27 -0400 Message-ID: <521DF3B0.5010008@redhat.com> Date: Wed, 28 Aug 2013 06:57:20 -0600 From: Eric Blake MIME-Version: 1.0 References: <1376368326-7433-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1376368326-7433-3-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1376368326-7433-3-git-send-email-wdongxu@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oMJRugjMRShCbuj230sEMLa6q2gX7oGKP" Subject: Re: [Qemu-devel] [PATCH V18 02/25] qemu-option: avoid duplication of default value in QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: kwolf@redhat.com, wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oMJRugjMRShCbuj230sEMLa6q2gX7oGKP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/12/2013 10:31 PM, Dong Xu Wang wrote: > This patch moves the default value entirely to QemuOptDesc. >=20 > When getting the value of an option that hasn't been set, and > QemuOptDesc has a default value, return that. Else, behave as > before. >=20 =2E.. > Else, return NULL. >=20 > Signed-off-by: Dong Xu Wang > Reviewed-by: Eric Blake >=20 > v13->v14: > 1) change code style. > 2) assert errors. >=20 > Signed-off-by: Dong Xu Wang >=20 > Conflicts: > util/qemu-option.c > --- Awkward. You should never have a 'Conflicts:' section on an upstream patch (except for maintainers resolving trivial conflicts during a merge operation); and this is another case of needing to move your submission changelog after the ---. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oMJRugjMRShCbuj230sEMLa6q2gX7oGKP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSHfOwAAoJEKeha0olJ0NqJK0IAIdUvy6XOWZx+CoRbGV/xr/D N6hzX2QRptq7yWyAGOuc6DkoOUl5rLY67vzM2vMrKRy+aldQCts7w1LiI6EkVSxg OrkVZJm0SdLKYRPOC/4ghEU/RW257BuXuSe7P9HWrcYHXZaPUj+H0cB/ANtEhQbG 386vjfml/MNy8sbmPJdt9/qliGCocqUsf0HMYH7BxhUEAO+xEImz/cNIwjIEh/iA b8Bmld2/cfY+7u3QOz28sG5P2kkliMJTv7hxOFULPoAW531O8A2uAaVmx6HhIpU6 olUIM1XndOWVscRgHrZnmP0Wq9qLHqQQXEsLe0LvACcAFQAZ4vcfCu9Mr2mwAOY= =ty0W -----END PGP SIGNATURE----- --oMJRugjMRShCbuj230sEMLa6q2gX7oGKP--