From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEi3Q-0003w5-I7 for qemu-devel@nongnu.org; Wed, 28 Aug 2013 11:53:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEhsy-0001s3-C4 for qemu-devel@nongnu.org; Wed, 28 Aug 2013 11:42:26 -0400 Message-ID: <521E1394.80404@redhat.com> Date: Wed, 28 Aug 2013 17:13:24 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1377693786-10844-1-git-send-email-kraxel@redhat.com> <1377693786-10844-12-git-send-email-kraxel@redhat.com> In-Reply-To: <1377693786-10844-12-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/10] Revert "usb-hub: report status changes only once" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org Hi, On 08/28/2013 02:43 PM, Gerd Hoffmann wrote: > This reverts commit a309ee6e0a256f690760abfba44fceaa52a7c2f3. > > This isn't in line with the usb specification and adds regressions, > win7 fails to drive the usb hub for example. > > Was added because it "solved" the issue of hubs interacting badly > with the xhci host controller. Now with the root cause being fixed > in xhci (commit ) we can revert this one. Maybe the FIXME in the commit msg should be fixed before this goes to master ?? Other then that this patch set looks good, great work! Regards, Hans