From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Alexander Graf <agraf@suse.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH qom-cpu/arm-devs] hw/cpu/a15mpcore: Use qemu_get_cpu() for generic timers
Date: Wed, 28 Aug 2013 17:35:32 +0200 [thread overview]
Message-ID: <521E18C4.2050308@suse.de> (raw)
In-Reply-To: <CAFEAcA8d339xj45TbaQcGXYnjq3eEXrt=eVKcscZ3R0EuKQ9Zg@mail.gmail.com>
Am 28.08.2013 17:22, schrieb Peter Maydell:
> On 28 August 2013 16:19, Andreas Färber <afaerber@suse.de> wrote:
>> Am 21.08.2013 18:45, schrieb Andreas Färber:
>>> This simplifies the loop and aids with refactoring of CPU list.
>>>
>>> Requested-by: Peter Maydell <peter.maydell@linaro.org>
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>> ---
>>> hw/cpu/a15mpcore.c | 5 ++---
>>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> Seeing no objection or pick-up from PMM I've applied this to qom-cpu
>> now, to move forward with CPU list refactoring.
>
> I wasn't sure how this patch fit with your larger series
> that redoes the a15mpcore/gic/etc (which I think I'm
> still waiting for an applyable patch set so I can review
> it); I think I thought it was an apply-afterwards thing.
This one needs to go before my qom-cpu-12 series to avoid the CPU loop
ugliness. That's in my CPU tree, and seeing no objections I still need
to test the p_greetings2.c sample for the CPU-removed case in linux-user
and will then merge that before we get more CPU loops.
For the MPCore series in my ARM/Tegra tree you wanted an assert for
object_initialize(). I am waiting for you to comment on my more
invasive/complete series (last part being optional), which would then
with any suggested changes go through my QOM tree before I add more uses
of object_initialize() that would need to be converted.
Based on that I will respin the MPCore, virtio and other QOM series.
> Anyway, I have no objection to it.
Thanks, want me to add some *-by?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-28 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 16:45 [Qemu-devel] [PATCH qom-cpu/arm-devs] hw/cpu/a15mpcore: Use qemu_get_cpu() for generic timers Andreas Färber
2013-08-28 15:19 ` Andreas Färber
2013-08-28 15:22 ` Peter Maydell
2013-08-28 15:35 ` Andreas Färber [this message]
2013-08-28 16:11 ` Peter Maydell
2013-08-28 16:16 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521E18C4.2050308@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).