From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VEiQa-0008H9-NC
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 12:17:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VEiQU-0006Jf-Oi
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 12:17:04 -0400
Received: from cantor2.suse.de ([195.135.220.15]:50334 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VEiQU-0006JP-II
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 12:16:58 -0400
Message-ID: <521E2277.8030009@suse.de>
Date: Wed, 28 Aug 2013 18:16:55 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1377103508-13496-1-git-send-email-afaerber@suse.de>
	<521E1510.9090804@suse.de>
	<CAFEAcA8d339xj45TbaQcGXYnjq3eEXrt=eVKcscZ3R0EuKQ9Zg@mail.gmail.com>
	<521E18C4.2050308@suse.de>
	<CAFEAcA-JNtdkvd2BZ_cf-wF6PeNEjofjSfWCOPnk29UuM5uxHw@mail.gmail.com>
In-Reply-To: <CAFEAcA-JNtdkvd2BZ_cf-wF6PeNEjofjSfWCOPnk29UuM5uxHw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu/arm-devs] hw/cpu/a15mpcore: Use
 qemu_get_cpu() for generic timers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

Am 28.08.2013 18:11, schrieb Peter Maydell:
> On 28 August 2013 16:35, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> For the MPCore series in my ARM/Tegra tree you wanted an assert for
>> object_initialize(). I am waiting for you to comment on my more
>> invasive/complete series (last part being optional), which would then
>> with any suggested changes go through my QOM tree before I add more us=
es
>> of object_initialize() that would need to be converted.
>=20
> Ah, OK. I'm moving house this week so probably won't get to
> detailed review til next week, but I think in general it looked OK.
> Having to pass "&X, sizeof(X)" in the most common case is
> a little unfortunate but I think the bus related code and so on
> convinced me it was necessary.

Yeah, it turned into more work than I expected ;) but there were at
least two cases (still need to reply) where the macro-fied version
would've checked the wrong thing and my patches are intentionally
deviating from the usual pattern - main_system_bus and a sec_bus.

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg