From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEihi-00089S-6i for qemu-devel@nongnu.org; Wed, 28 Aug 2013 12:34:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEihZ-0004kc-R3 for qemu-devel@nongnu.org; Wed, 28 Aug 2013 12:34:46 -0400 Received: from mail-yh0-x234.google.com ([2607:f8b0:4002:c01::234]:63250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEihZ-0004kY-MJ for qemu-devel@nongnu.org; Wed, 28 Aug 2013 12:34:37 -0400 Received: by mail-yh0-f52.google.com with SMTP id a41so1127211yho.25 for ; Wed, 28 Aug 2013 09:34:37 -0700 (PDT) Sender: Richard Henderson Message-ID: <521E2699.6010803@twiddle.net> Date: Wed, 28 Aug 2013 09:34:33 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1377639991-16028-1-git-send-email-rth@twiddle.net> <1377639991-16028-8-git-send-email-rth@twiddle.net> In-Reply-To: <1377639991-16028-8-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] tcg-i386: Perform tail call to qemu_ret_ld*_mmu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aurelien@aurel32.net On 08/27/2013 02:46 PM, Richard Henderson wrote: > - { INDEX_op_qemu_ld8u, { "r", "L" } }, > - { INDEX_op_qemu_ld8s, { "r", "L" } }, > - { INDEX_op_qemu_ld16u, { "r", "L" } }, > - { INDEX_op_qemu_ld16s, { "r", "L" } }, > - { INDEX_op_qemu_ld32, { "r", "L" } }, > - { INDEX_op_qemu_ld32u, { "r", "L" } }, > - { INDEX_op_qemu_ld32s, { "r", "L" } }, > - { INDEX_op_qemu_ld64, { "r", "L" } }, > + { INDEX_op_qemu_ld8u, { "a", "L" } }, > + { INDEX_op_qemu_ld8s, { "a", "L" } }, > + { INDEX_op_qemu_ld16u, { "a", "L" } }, > + { INDEX_op_qemu_ld16s, { "a", "L" } }, > + { INDEX_op_qemu_ld32, { "a", "L" } }, > + { INDEX_op_qemu_ld32u, { "a", "L" } }, > + { INDEX_op_qemu_ld32s, { "a", "L" } }, > + { INDEX_op_qemu_ld64, { "a", "L" } }, I should have invented a new constraint letter here. While this works, and is ideal for softmmu, this unnecessarily penalizes non-softmmu. r~