From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEjoc-0007Qg-T2 for qemu-devel@nongnu.org; Wed, 28 Aug 2013 13:46:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEjoT-0003c9-7I for qemu-devel@nongnu.org; Wed, 28 Aug 2013 13:45:58 -0400 Received: from mail-gh0-x22f.google.com ([2607:f8b0:4002:c05::22f]:58766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEjoS-0003bx-So for qemu-devel@nongnu.org; Wed, 28 Aug 2013 13:45:49 -0400 Received: by mail-gh0-f175.google.com with SMTP id z19so1605309ghb.20 for ; Wed, 28 Aug 2013 10:45:48 -0700 (PDT) Sender: Richard Henderson Message-ID: <521E3747.4070709@twiddle.net> Date: Wed, 28 Aug 2013 10:45:43 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1377664796-11698-1-git-send-email-sw@weilnetz.de> <521E09DF.20102@twiddle.net> <521E16B3.3030008@twiddle.net> <521E3086.1030003@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] Streamlining endian handling in TCG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel , Aurelien Jarno On 08/28/2013 10:28 AM, Peter Maydell wrote: > Well, what do ldl_p or ldl_phys or any of the other functions > without an le/be qualifier mean any more if "is this CPU in > big endian mode?" now requires you to have a CPUState > to ask? I guess we can tackle that separately from getting > the assumptions on endianness out of the tcg backends > though. ldl_p is the host native endian unaligned load primitive. ldl_phys is the one that'll need to be adjusted or eliminated. >>From a quick glance, this doesn't look too bad. Most of the uses are in the target-* directories already, and mostly for emulating page tables. Those should be trivial to adjust as needed. The troublesome offender appears to be virtio. I know some discussion of cleaning that up has happened in the context of LE PowerPC, but I didn't really follow what went on there. r~