From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VErNE-0006gv-6A for qemu-devel@nongnu.org; Wed, 28 Aug 2013 21:50:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VErN5-0003YL-6V for qemu-devel@nongnu.org; Wed, 28 Aug 2013 21:50:12 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:44096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VErN4-0003Vg-VP for qemu-devel@nongnu.org; Wed, 28 Aug 2013 21:50:03 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 28 Aug 2013 19:50:02 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id A86AD19D8036 for ; Wed, 28 Aug 2013 19:49:59 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7T1nxNo053902 for ; Wed, 28 Aug 2013 19:49:59 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7T1qqZu026240 for ; Wed, 28 Aug 2013 19:52:52 -0600 Message-ID: <521EA8C4.8010608@linux.vnet.ibm.com> Date: Thu, 29 Aug 2013 09:49:56 +0800 From: Dong Xu Wang MIME-Version: 1.0 References: <1376368326-7433-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1376368326-7433-2-git-send-email-wdongxu@linux.vnet.ibm.com> <521DF2E6.7080109@redhat.com> In-Reply-To: <521DF2E6.7080109@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com On 2013/8/28 20:53, Eric Blake wrote: > On 08/12/2013 10:31 PM, Dong Xu Wang wrote: >> qemu_opts_print has no user now, so can re-write the function safely. >> >> qemu_opts_print is used while using "qemu-img create", it >> produces the same output as previous code. >> >> The behavior of this function has changed: >> >> 1. Print every possible option, whether a value has been set or not. >> 2. Option descriptors may provide a default value. >> 3. Print to stdout instead of stderr. >> >> Previously the behavior was to print every option that has been set. >> Options that have not been set would be skipped. >> >> v17->v18: >> 1) print opt->value.uint directly while type is QEMU_OPT_SIZE. > > When making a change to a previously-reviewed patch, unrelated to the > reviewer's comments... > >> >> Reviewed-by: Eric Blake >> Signed-off-by: Dong Xu Wang > > ...it is probably better to drop the earlier Reviewed-by: to make sure > that the change gets properly reviewed. Keeping a Reviewed-by makes > sense only when carrying a patch with no changes, or when the set of > changes made are trivial in nature (such as whitespace cleanups) or > explicitly mentioned as the changes desired by the reviewer. > Okay, thank you, Eric.