From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Paul Mackerras" <paulus@samba.org>,
"Andreas Färber" <afaerber@suse.de>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN
Date: Thu, 29 Aug 2013 18:18:52 +1000 [thread overview]
Message-ID: <521F03EC.80908@ozlabs.ru> (raw)
In-Reply-To: <315B31BA-FE61-45CA-A1C1-F1E67702E5F4@suse.de>
On 08/27/2013 06:36 PM, Alexander Graf wrote:
>
> On 27.08.2013, at 06:10, Benjamin Herrenschmidt wrote:
>
>> On Tue, 2013-08-27 at 03:48 +0200, Andreas Färber wrote:
>>> Also, QEMU is definitely not the only project that has higher
>>> acceptance
>>> criteria than patch-works-for-the-patch-author. :)
>>
>> There's a difference between high acceptance criteria and systematic
>> bike shed painting including in some case request to turn reasonably
>> meaningful identifiers into something that nobody would get :-)
>
> The name doesn't tell at all what the function is doing. This is even true for the kernel ioctl, but that one is in now, so it's there to stay. Heck, I even had to look up the API documentation to know whether this sets an RTAS to be handled in-kernel or in-user-space.
>
> Just come up with a good name and all is well. Or are you enjoying to complain on every patch review I do now?
So - kvmppc_define_rtas_in_kernel() or kvmppc_define_rtas_kernel_token()?
I would actually though that the very first "k" is for "Kernel" already but...
--
Alexey
next prev parent reply other threads:[~2013-08-29 8:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 5:55 [Qemu-devel] [PATCH v3 0/8] xics: reworks and in-kernel support Alexey Kardashevskiy
2013-08-19 5:55 ` [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN Alexey Kardashevskiy
2013-08-26 13:11 ` Alexander Graf
2013-08-27 0:43 ` Benjamin Herrenschmidt
2013-08-27 1:48 ` Andreas Färber
2013-08-27 4:10 ` Benjamin Herrenschmidt
2013-08-27 8:36 ` Alexander Graf
2013-08-29 8:18 ` Alexey Kardashevskiy [this message]
2013-08-30 14:34 ` Alexander Graf
2013-08-30 22:19 ` Benjamin Herrenschmidt
2013-08-30 23:04 ` Alexander Graf
2013-08-30 20:05 ` Laszlo Ersek
2013-08-19 5:55 ` [Qemu-devel] [PATCH v3 2/8] xics: add pre_save/post_load/cpu_setup dispatchers Alexey Kardashevskiy
2013-08-19 13:54 ` Andreas Färber
2013-08-23 3:39 ` Alexey Kardashevskiy
2013-08-23 11:38 ` Andreas Färber
2013-08-29 8:25 ` Alexey Kardashevskiy
2013-08-29 8:32 ` Andreas Färber
2013-08-26 13:22 ` Alexander Graf
2013-08-19 5:55 ` [Qemu-devel] [PATCH v3 3/8] xics: move registration of global state to realize() Alexey Kardashevskiy
2013-08-26 13:27 ` Alexander Graf
2013-08-19 5:55 ` [Qemu-devel] [PATCH v3 4/8] xics: minor changes and cleanups Alexey Kardashevskiy
2013-08-26 13:36 ` Alexander Graf
2013-08-26 14:20 ` Andreas Färber
2013-08-26 14:31 ` Alexander Graf
2013-08-19 5:55 ` [Qemu-devel] [PATCH v3 5/8] xics: split to xics and xics-common Alexey Kardashevskiy
2013-08-26 13:40 ` Alexander Graf
2013-08-19 5:55 ` [Qemu-devel] [PATCH v3 6/8] xics-kvm: Support for in-kernel XICS interrupt controller Alexey Kardashevskiy
2013-08-27 9:28 ` Alexander Graf
2013-08-29 8:37 ` Andreas Färber
2013-08-29 8:53 ` Alexey Kardashevskiy
2013-08-30 0:10 ` Anthony Liguori
2013-08-23 11:56 ` [Qemu-devel] [PATCH v3 0/8] xics: reworks and in-kernel support Andreas Färber
2013-08-23 12:05 ` Alexey Kardashevskiy
2013-08-23 12:02 ` [Qemu-devel] [PATCH v3] xics: Add H_IPOLL implementation Alexey Kardashevskiy
2013-08-27 9:34 ` Alexander Graf
2013-08-23 12:03 ` [Qemu-devel] [PATCH v3] xics: Implement H_XIRR_X Alexey Kardashevskiy
2013-08-27 9:35 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F03EC.80908@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=david@gibson.dropbear.id.au \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).