From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VExeI-0002c8-C3 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 04:32:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VExeC-0007lI-4Q for qemu-devel@nongnu.org; Thu, 29 Aug 2013 04:32:14 -0400 Message-ID: <521F0701.8080206@suse.de> Date: Thu, 29 Aug 2013 10:32:01 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1376891726-26122-1-git-send-email-aik@ozlabs.ru> <1376891726-26122-3-git-send-email-aik@ozlabs.ru> <521223A4.2010205@suse.de> <5216D960.8010406@ozlabs.ru> <521749A3.2060001@suse.de> <521F0584.7050409@ozlabs.ru> In-Reply-To: <521F0584.7050409@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/8] xics: add pre_save/post_load/cpu_setup dispatchers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, Alexander Graf , Paul Mackerras , Anthony Liguori , qemu-ppc@nongnu.org, David Gibson Am 29.08.2013 10:25, schrieb Alexey Kardashevskiy: > On 08/23/2013 09:38 PM, Andreas F=C3=A4rber wrote: >> Am 23.08.2013 05:39, schrieb Alexey Kardashevskiy: >>> On 08/19/2013 11:54 PM, Andreas F=C3=A4rber wrote: >>>> Am 19.08.2013 07:55, schrieb Alexey Kardashevskiy: >>>>> The upcoming support of in-kernel XICS will redefine migration call= backs >>>>> for both ICS and ICP so classes and callback pointers are added. >>>>> >>>>> This adds a cpu_setup callback to the XICS device class (as XICS-KV= M >>>>> will do it different) and xics_dispatch_cpu_setup(). This also move= s >>>>> the place where xics_dispatch_cpu_setup() is called a bit further t= o >>>>> have VCPU initialized (required for XICS-KVM). >>>>> >>>>> Signed-off-by: Alexey Kardashevskiy >>>>> --- >>>>> Changes: >>>>> v3: >>>>> * fixed local variables names >>>>> --- >>>>> hw/intc/xics.c | 61 +++++++++++++++++++++++++++++++++++++++= ++++++++---- >>>>> hw/ppc/spapr.c | 4 ++-- >>>>> include/hw/ppc/xics.h | 46 +++++++++++++++++++++++++++++++++++++- >>>>> 3 files changed, 104 insertions(+), 7 deletions(-) >>>>> >>>>> diff --git a/hw/intc/xics.c b/hw/intc/xics.c >>>>> index 6b3c071..e3a957d 100644 >>>>> --- a/hw/intc/xics.c >>>>> +++ b/hw/intc/xics.c >>>> [...] >>>>> @@ -674,10 +724,12 @@ static Property xics_properties[] =3D { >>>>> static void xics_class_init(ObjectClass *oc, void *data) >>>>> { >>>>> DeviceClass *dc =3D DEVICE_CLASS(oc); >>>>> + XICSStateClass *k =3D XICS_CLASS(oc); >>>>> =20 >>>>> dc->realize =3D xics_realize; >>>>> dc->props =3D xics_properties; >>>>> dc->reset =3D xics_reset; >>>>> + k->cpu_setup =3D xics_cpu_setup; >>>>> =20 >>>>> spapr_rtas_register("ibm,set-xive", rtas_set_xive); >>>>> spapr_rtas_register("ibm,get-xive", rtas_get_xive); >>>> >>>> This hunk is fixed up in 4/8, please squash that bit here. >>> >>> Thanks for the review, fixed this. >>> >>> >>>> Otherwise looks good. >>> >>> What exactly looks good? This patch only? >> >> Yes. And another one has by Rb already I believe. I hope Alex can star= t >> cherry-picking some more patches when he gets back to NUE. >=20 >> I know you had some open questions I still need to reply to. Among >> others, yes, I concur with mst that ppc/spapr_pci.c could be moved to >> pci-host/spapr.c, but remember to update MAINTAINERS for you guys to >> still get CC'ed on it then. >> >> I had asked Anthony to reply to the KVM XICS patch >> because he said that >=20 > Do we really expect Anthony to reply? He seems to disappear from this > conversation and Alex already Rb'ed that patch. >=20 >> accessing the parent's method seemed wrong to him and the parent >> implement should be put in charge of calling rather than the derived. >> I.e., I will be dropping my proposed OBJECT_GET_PARENT_CLASS() macro a= nd >> started redoing several series. Haven't looked into how exactly your >> code (CPU setup I think?) may need to change. >=20 >=20 > xics_dispatch_cpu_setup() should call XICS common's cpu_setup which mus= t > call then KVM-XICS's cpu_setup? I do not follow you here, sorry. I assume Anthony meant to have xics_dispatch_cpu_setup() or whatever to contain the common logic and call cpu_setup hook *only* for the emulation/KVM specific logic. But that's what he was/is supposed to explain himself. :) He is CC'ed and if he doesn't reply, ping him. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg