From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VExwJ-0002xM-5k for qemu-devel@nongnu.org; Thu, 29 Aug 2013 04:50:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VExwC-0005qp-7o for qemu-devel@nongnu.org; Thu, 29 Aug 2013 04:50:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VExwB-0005qf-VR for qemu-devel@nongnu.org; Thu, 29 Aug 2013 04:50:44 -0400 Message-ID: <521F0B5C.3090102@redhat.com> Date: Thu, 29 Aug 2013 10:50:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377170965-9905-1-git-send-email-aik@ozlabs.ru> <1377170965-9905-4-git-send-email-aik@ozlabs.ru> <1377703099.10408.71.camel@ul30vt.home> <521E9DF5.9080709@ozlabs.ru> <1377740545.10408.145.camel@ul30vt.home> <521EB16F.9010303@ozlabs.ru> <521EEA64.7000708@redhat.com> <521EF0FD.5080906@ozlabs.ru> In-Reply-To: <521EF0FD.5080906@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 3/3] vfio: Fix 128 bit handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Peter Maydell , Alex Williamson , qemu-devel@nongnu.org Il 29/08/2013 08:58, Alexey Kardashevskiy ha scritto: > On 08/29/2013 04:29 PM, Paolo Bonzini wrote: >> Il 29/08/2013 04:26, Alexey Kardashevskiy ha scritto: >>> >>> Right. I was planning to add my IOMMU stuff right before calculating @end. >> >> But then the non-IOMMU stuff can just use int128_get64, no? So even if >> this patch simply uses int128_get64, it is still a suitable basis for >> adding IOMMU stuff. > > Suitable but ugly. What if before calling int128_get64, I test > section->size if it is <2^64 and only then do RAM part of this function? What if you just merge the two series together? Paolo