From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEykU-0002R2-H9 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 05:42:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEykJ-00054V-7v for qemu-devel@nongnu.org; Thu, 29 Aug 2013 05:42:42 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:50886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEykJ-000540-0z for qemu-devel@nongnu.org; Thu, 29 Aug 2013 05:42:31 -0400 Received: by mail-bk0-f44.google.com with SMTP id mz10so67453bkb.17 for ; Thu, 29 Aug 2013 02:42:30 -0700 (PDT) Message-ID: <521F178C.2020506@m2r.biz> Date: Thu, 29 Aug 2013 11:42:36 +0200 From: Fabio Fantoni MIME-Version: 1.0 References: <1376664409-2695-1-git-send-email-anthony.perard@citrix.com> <521F0DB6.9090203@redhat.com> In-Reply-To: <521F0DB6.9090203@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH for v1.6] pc: Fix initialization of the ram_memory variable. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Anthony PERARD , qemu-trivial@nongnu.org, Stefano Stabellini , QEMU-devel , Xen Devel Il 29/08/2013 11:00, Paolo Bonzini ha scritto: > Il 16/08/2013 16:46, Anthony PERARD ha scritto: >> In some cases (Xen), it will not be initialized before to be used. This >> leads to segv. >> >> Signed-off-by: Anthony PERARD >> >> --- >> >> It works with this simple initialization to NULL, but would it be >> necessary (or better) to assign a proper value to this variables ? > Yeah, the right value of this variable comes from xen_ram_init (called > by xen_hvm_init). > > Paolo I done a fast search of patch between 1.5 and 1.6 about memory on xen files and I found this patch: Commit:2c9b15cab12c21e32dffb67c5e18f3dc407ca224 * memory: add owner argument to initialization functions I not understand if can be this that have introduced an unexpected event with xen and how to solve correctly. Thanks for any reply and sorry for my bad english. > >> --- >> hw/i386/pc_piix.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >> index 6e1e654..596d433 100644 >> --- a/hw/i386/pc_piix.c >> +++ b/hw/i386/pc_piix.c >> @@ -86,7 +86,7 @@ static void pc_init1(MemoryRegion *system_memory, >> BusState *idebus[MAX_IDE_BUS]; >> ISADevice *rtc_state; >> ISADevice *floppy; >> - MemoryRegion *ram_memory; >> + MemoryRegion *ram_memory = NULL; >> MemoryRegion *pci_memory; >> MemoryRegion *rom_memory; >> DeviceState *icc_bridge; >> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel