From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF1LP-0001Xi-8V for qemu-devel@nongnu.org; Thu, 29 Aug 2013 08:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VF1LK-00010g-E6 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 08:28:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF1LK-000106-4j for qemu-devel@nongnu.org; Thu, 29 Aug 2013 08:28:54 -0400 Message-ID: <521F3E7D.5050207@redhat.com> Date: Thu, 29 Aug 2013 06:28:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <97ad5a7092e78bc4fbc40427813208f1bb6792cb.1377691274.git.chen.fan.fnst@cn.fujitsu.com> In-Reply-To: <97ad5a7092e78bc4fbc40427813208f1bb6792cb.1377691274.git.chen.fan.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pCgvqn7VcHXfenPQQUa3R4FG3dnBXRnCS" Subject: Re: [Qemu-devel] [RFC][PATCH 4/6] qmp: add 'cpu-del' command support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan Cc: Igor Mammedov , qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pCgvqn7VcHXfenPQQUa3R4FG3dnBXRnCS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/28/2013 08:09 PM, Chen Fan wrote: > Signed-off-by: Chen Fan > --- > hw/i386/pc.c | 5 +++++ > hw/i386/pc_piix.c | 1 + > include/hw/boards.h | 2 ++ > include/hw/i386/pc.h | 1 + > qapi-schema.json | 12 ++++++++++++ > qmp-commands.hx | 23 +++++++++++++++++++++++ > qmp.c | 9 +++++++++ > 7 files changed, 53 insertions(+) >=20 > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index c0e7cbd..75fc9bb 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -958,6 +958,11 @@ void pc_hot_add_cpu(const int64_t id, Error **errp= ) > pc_new_cpu(current_cpu_model, apic_id, icc_bridge, errp); > } > =20 > +void pc_hot_del_cpu(const int64_t id, Error **errp) > +{ > + /* TODO: hot remove VCPU. */ > +} That seems fishy. > +++ b/qapi-schema.json > @@ -1432,6 +1432,18 @@ > ## > { 'command': 'cpu-add', 'data': {'id': 'int'} } > =20 > +# @cpu-del > + > +# Deletes CPU with specified ID > +# > +# @id: ID of CPU to be deleted, valid values [0..max_cpus) > +# > +# Returns: Nothing on success > +# > +# Since 1.6 1.6 is already out the door. This must be 1.7. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pCgvqn7VcHXfenPQQUa3R4FG3dnBXRnCS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSHz59AAoJEKeha0olJ0Nq0/EIAKEZr36isOnicI5zMbkp1eD0 B9GEnfD3hiycCgxLIm8qKQ6EMzjKYF9IVdl4PKvNh+raHuZPATrJQgTSg36MzgDc E+6dbPleDbfZpeAlKZU7uOfy/NvY65ulzQ/+L4w/CCwagODSnpuQZW7UnIF2cm5H c2qvMiIVONTMkqfxrLRwgKoG2ARXiGyymvk0Y5WLpF72Zx/vHZhlAz6MexXD29+N LLOPOkp1Ql7G51+ejIdCIA8iJiHPIUtqRU0vde7QbtqotPwaVi5VBC4rEMsjwhyh ffqL1ZkrevmXhtz8KBbuCL6hpCr44NpGGCLK/tawwrYfPvOXh54prHGpiTtK2k0= =RDzF -----END PGP SIGNATURE----- --pCgvqn7VcHXfenPQQUa3R4FG3dnBXRnCS--