From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF1NI-0003ET-0k for qemu-devel@nongnu.org; Thu, 29 Aug 2013 08:31:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VF1NC-0001zq-JU for qemu-devel@nongnu.org; Thu, 29 Aug 2013 08:30:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF1NC-0001zW-0O for qemu-devel@nongnu.org; Thu, 29 Aug 2013 08:30:50 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7TCUmhE018857 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Aug 2013 08:30:49 -0400 Message-ID: <521F3EF7.1070303@redhat.com> Date: Thu, 29 Aug 2013 06:30:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377771363-5198-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1377771363-5198-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ObLiTK2oHQfUHGjr85ElXlIoKO8nmcwfh" Subject: Re: [Qemu-devel] [PATCH] qcow2-refcount: Snapshot update for zero clusters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ObLiTK2oHQfUHGjr85ElXlIoKO8nmcwfh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/29/2013 04:16 AM, Max Reitz wrote: > Do not try to update the refcount for zero clusters in > qcow2_update_snapshot_refcount. Why? What does this fix? (Hint - your commit message could use more details, and you should add a testsuite addition that exposes the case that you are fixing) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ObLiTK2oHQfUHGjr85ElXlIoKO8nmcwfh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSHz73AAoJEKeha0olJ0NqKtcH+wYl5FZrlU9RA1MYQWUJ6c20 /PiWplbXZZnjApd981+HslOZAV5eJMbu8KcGst7NnDwX+KrwDWA7jN8ILkNvdLFq pgWI+U2gIrS793Fzf73qeTfSW8yrn/kAPOKsL11hWAIeZvAZFCmVfy5wzhhc6YIl QZKQHecJYc1gxxeuNG4s33yuIysuASSAkzsj+PSFXTvnemrhmd+KHkMuDmAflM1b 7jHguXdTgrroxVlWVytU7RLCCJotIx6ICbrhZ8R/ccFlgJ3m28bvs5uqVmBks75C Ri78PY4jv3sOjWT4Z8tUkah4zX9APNDAoN9mQZSXDAKubm2F1uBrCTObCZx02JI= =bQ/h -----END PGP SIGNATURE----- --ObLiTK2oHQfUHGjr85ElXlIoKO8nmcwfh--