From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF1Rm-0001sc-38 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 08:35:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VF1Rf-0004Zt-32 for qemu-devel@nongnu.org; Thu, 29 Aug 2013 08:35:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF1Re-0004Zo-RM for qemu-devel@nongnu.org; Thu, 29 Aug 2013 08:35:27 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7TCZQvk004900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Aug 2013 08:35:26 -0400 Message-ID: <521F400C.1050102@redhat.com> Date: Thu, 29 Aug 2013 14:35:24 +0200 From: Max Reitz MIME-Version: 1.0 References: <1377771363-5198-1-git-send-email-mreitz@redhat.com> <521F3EF7.1070303@redhat.com> In-Reply-To: <521F3EF7.1070303@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2-refcount: Snapshot update for zero clusters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi Am 29.08.2013 14:30, schrieb Eric Blake: > On 08/29/2013 04:16 AM, Max Reitz wrote: >> Do not try to update the refcount for zero clusters in >> qcow2_update_snapshot_refcount. > Why? What does this fix? > > (Hint - your commit message could use more details, and you should add a > testsuite addition that exposes the case that you are fixing) > Okay, I'll put more detail into the message. The test case is actually kind of contained in my series "block/qcow2: Image file option amendment", but, of course, you're right, a dedicated test case won't hurt. Max