From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF4Bi-00087l-Dj for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:31:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VF4Bc-0005R5-Ts for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:31:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF4Bc-0005Qs-LA for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:31:04 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7TFV3qd018588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Aug 2013 11:31:04 -0400 Message-ID: <521F6936.9050908@redhat.com> Date: Thu, 29 Aug 2013 09:31:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377784821-29561-1-git-send-email-pbonzini@redhat.com> <1377784821-29561-18-git-send-email-pbonzini@redhat.com> In-Reply-To: <1377784821-29561-18-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UnSeAqBjioCHFlmrfH9OPH7uMMlvoaJqg" Subject: Re: [Qemu-devel] [PATCH v4 17/21] docs, qapi: document qemu-img map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UnSeAqBjioCHFlmrfH9OPH7uMMlvoaJqg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/29/2013 08:00 AM, Paolo Bonzini wrote: > Eric Blake also requested including the output in qapi-schema.json, > so that it is published through the introspection mechanism. >=20 > Signed-off-by: Paolo Bonzini > --- > qapi-schema.json | 29 +++++++++++++++++++++++++++++ > qemu-img.texi | 55 ++++++++++++++++++++++++++++++++++++++++++++++++= +++++++ > 2 files changed, 84 insertions(+) >=20 > +# @offset: if present, the image file stores the data for this range i= n > +# raw format at the given offset. > +# > +# Since 1.6 We missed that boat. 1.7 now. > +## > +{ 'type': 'BlockDeviceMapEntry', > + 'data': { 'start': 'int', 'length': 'int', 'depth': 'int', 'zero': '= bool', > + 'data': 'bool', '*offset': 'int' } } Fix that, and you can add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UnSeAqBjioCHFlmrfH9OPH7uMMlvoaJqg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSH2k3AAoJEKeha0olJ0NqQ6kH/21zUv+hR4IFlf4S6JqKBJOf NfsV01KZQG+TBzeVfGJBiKEZeFWw4oKm9PmmQz2sZchXBXgOsPGp7wqpmjgjRnGl FKEfq+5BGtXYyxUQzSW1P5anQkLnb+gnRaIHfvx/mUSgv766D1ixLDH3WOTOktRd Qm/BFcg1edYjl5pqi2sEwgSef/JgkX5M2kvIFCFN34Rb3pQAOjfRXMlj2awuUrgN 7u6MCrZ3Z2w7LKonyTeKTnVDdTlKqD5f5HJt4YfFme5obB21BVkayq3TV/cKiSom KYEWqMxTDpOpTBsTkOaw4fe3FeJkXPOLonOo+81pXoMgMOsafLgAwM46quGozho= =riol -----END PGP SIGNATURE----- --UnSeAqBjioCHFlmrfH9OPH7uMMlvoaJqg--