Re: [Qemu-devel] [PATCH 2/2] add some virtio-scsi trace events

[Laszlo Ersek <lersek@redhat.com>]

On 08/29/13 16:53, Paolo Bonzini wrote:

>> (c) The way I submitted the series, the events in question are disabled
>> in "trace-events". Check out the functions themselves: they are
>> protected (ie. even the trace_event_get_state() calls are protected)
>> with preprocessing directives. I did it this way because I call them in
>> several places, and I wanted to keep the #if's centralized.
> 
> Tracing was supposed to remove the need for #if... :)

Tracing was supposed not to be broken under dtrace either I presume?

> I'll try to salvage the patch.

I won't bother next time. I wouldn't want you to waste your time on
"salvaging" the clearly broken patches that I submit.

To be clear, I considered this series a favor. I don't need it to be
accepted. It's easier for me to write ad-hoc debug printf()s each time.
They don't depend on anything, they can print just the right set of info
that I need, and they work in any component imaginable.

In comparison, the bikeshedding you repeatedly indulge in is unbearable.
You keep splitting hairs and rejecting patches just because they are not
in your taste; you don't need any other reason.

NB I haven't just thrown this over the wall. I spent most of today on
this series and tried to cover all my bases, perusing the documentation,
testing the series, making an honest effort. The one thing that I
*can't* prepare for is your adoration of your own taste.

If you attribute such paramount importance to your taste, perhaps next
time write the crap yourself that you tend to ask me for.

Of course there are times when I can't just ignore you and walk away.
Maybe I'll look for different responsibilities if that becomes the norm.

Laszlo