From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] add some virtio-scsi trace events
Date: Thu, 29 Aug 2013 17:42:23 +0200 [thread overview]
Message-ID: <521F6BDF.5070008@redhat.com> (raw)
In-Reply-To: <521F6A3C.5060702@redhat.com>
Il 29/08/2013 17:35, Laszlo Ersek ha scritto:
> On 08/29/13 16:53, Paolo Bonzini wrote:
>> I'll try to salvage the patch.
>
> I won't bother next time. I wouldn't want you to waste your time on
> "salvaging" the clearly broken patches that I submit.
WTF?
The patch is clearly a good thing, or I wouldn't have asked you to send it.
However, if you don't have time to follow up on my comments, all that a
maintainer can do is:
(1) ignore it and/or let it rot
(2) pick it up and gain something from a patch that isn't quite ready.
#2 is exactly the definition of salvage.
> To be clear, I considered this series a favor.
Sure, and it's very welcome. But you shouldn't expect too much from
your interlocutor after writing "I don't have any more time for this".
If you don't have any more time for this, next time send me the patch
privately and say it in advance before I even start reviewing it. I'll
make sure you're properly acknowledged with From and Signed-off-by headers.
Paolo, glad that this time he's on the receiving edge of a flame...
next prev parent reply other threads:[~2013-08-29 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 13:36 [Qemu-devel] [PATCH 0/2] some virtio-scsi tracing Laszlo Ersek
2013-08-29 13:37 ` [Qemu-devel] [PATCH 1/2] qemu_hexstr(): hexdump a small buffer to a string, for in-line printing Laszlo Ersek
2013-08-29 16:32 ` Markus Armbruster
2013-08-29 13:37 ` [Qemu-devel] [PATCH 2/2] add some virtio-scsi trace events Laszlo Ersek
2013-08-29 13:59 ` Paolo Bonzini
2013-08-29 14:18 ` Laszlo Ersek
2013-08-29 14:53 ` Paolo Bonzini
2013-08-29 15:35 ` Laszlo Ersek
2013-08-29 15:42 ` Paolo Bonzini [this message]
2013-09-04 14:21 ` Stefan Hajnoczi
2013-09-05 1:26 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F6BDF.5070008@redhat.com \
--to=pbonzini@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).