From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF6G2-0003hP-Uk for qemu-devel@nongnu.org; Thu, 29 Aug 2013 13:43:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VF6Fu-0001AM-DN for qemu-devel@nongnu.org; Thu, 29 Aug 2013 13:43:46 -0400 Received: from mail-vb0-x230.google.com ([2607:f8b0:400c:c02::230]:59736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF6Fu-0001AE-8b for qemu-devel@nongnu.org; Thu, 29 Aug 2013 13:43:38 -0400 Received: by mail-vb0-f48.google.com with SMTP id w16so544800vbf.21 for ; Thu, 29 Aug 2013 10:43:37 -0700 (PDT) Sender: Richard Henderson Message-ID: <521F8845.3020102@twiddle.net> Date: Thu, 29 Aug 2013 10:43:33 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1377639991-16028-1-git-send-email-rth@twiddle.net> <1377639991-16028-8-git-send-email-rth@twiddle.net> <20130829170622.GP5908@ohm.aurel32.net> In-Reply-To: <20130829170622.GP5908@ohm.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] tcg-i386: Perform tail call to qemu_ret_ld*_mmu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 08/29/2013 10:06 AM, Aurelien Jarno wrote: > On Tue, Aug 27, 2013 at 02:46:31PM -0700, Richard Henderson wrote: >> This does require the fast path always load to the function return >> value register, but apparently the loaded value usually needs to be >> spilled back to its memory slot anyway so the change in register >> does not really change much. > > My suggestion was to only do that for the store, not for the load. Ah, ok. Fair enough. Shall I include the tail-call for store only if it saves code space, due any possible concern for call-return stack? I'm thinking here of PPC, which is 100% space neutral on this, exchanging one B for one MTLR in order to implement the tail call. r~