From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39076)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VF6Pu-0006Vl-AG
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 13:54:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VF6Pl-0005Hy-TW
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 13:53:58 -0400
Received: from mail-vb0-x235.google.com ([2607:f8b0:400c:c02::235]:46391)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VF6Pl-0005Ht-P4
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 13:53:49 -0400
Received: by mail-vb0-f53.google.com with SMTP id i3so571542vbh.12
	for <qemu-devel@nongnu.org>; Thu, 29 Aug 2013 10:53:49 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <521F8AA8.7080703@twiddle.net>
Date: Thu, 29 Aug 2013 10:53:44 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1377190729-14008-1-git-send-email-rth@twiddle.net>
	<1377190729-14008-18-git-send-email-rth@twiddle.net>
	<20130829164511.GA22155@ohm.aurel32.net>
In-Reply-To: <20130829164511.GA22155@ohm.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 17/18] tcg-i386: Adjust tcg_out_tlb_load
 for x32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 08/29/2013 09:45 AM, Aurelien Jarno wrote:
>> > -    tcg_out_mov(s, type, r1, addrlo);
>> > +    tcg_out_mov(s, ttype, r1, addrlo);
> This one is not fully correct. It should be ttype for the slow path (the
> value is used as an argument to the helper function), but htype for the
> fast path (the value is used as a host pointer).
> 
> Using ttype currently ensures the type is safe, but it might worth
> adding a comment in case ttype or htype is changed.

You're right, I'm not zero-extending the register properly for the fast path,
in the case of a 64-bit guest.

Although I could save more space on the fast path for x32 by avoiding the
copy/zero-extension here and instead using the ADDR32 prefix on the actual
memory operation.

Will fix.


r~