From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH-for-9.1 3/7] monitor: Rework stubs to simplify user emulation linking
Date: Mon, 8 Apr 2024 12:59:42 +0200 [thread overview]
Message-ID: <521b4a1c-2762-4dc7-b9fa-ffa6a8250a13@linaro.org> (raw)
In-Reply-To: <CABgObfb=Yfd55YiYgrN0YBN+bpZxJs4XHpac4t=kupHKm6oS0w@mail.gmail.com>
On 8/4/24 11:50, Paolo Bonzini wrote:
> On Thu, Apr 4, 2024 at 9:48 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> Currently monitor stubs are scattered in 3 files.
>>
>> Merge these stubs in 2 files, a generic one (monitor-core)
>> included in all builds (in particular user emulation), and
>> a less generic one to be included by tools and system emulation.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> stubs/fdset.c | 17 -----------------
>
> Oops, merging fdset.c breaks storage-daemon linking.
Odd. My 'tools_only' build directory is configured with:
'--enable-tools' '--disable-docs' '--disable-system' '--disable-user'
I was building qemu-img & co. I just checked it isn't anymore,
the directory only contains libqemuutil.a, libqom.fa,
libevent-loop-base.fa and tests/unit (I'm on macOS host).
This explained why I missed the link failure. I'll dig to
see when these tools disappeared on macOS.
Regards,
Phil.
next prev parent reply other threads:[~2024-04-08 11:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 19:47 [PATCH-for-9.1 0/7] buildsys: Start shrinking qemu-user build process Philippe Mathieu-Daudé
2024-04-04 19:47 ` [PATCH-for-9.1 1/7] ebpf: Restrict to system emulation Philippe Mathieu-Daudé
2024-04-04 22:14 ` Richard Henderson
2024-04-08 6:29 ` Jason Wang
2024-04-04 19:47 ` [PATCH-for-9.1 2/7] yank: " Philippe Mathieu-Daudé
2024-04-04 22:15 ` Richard Henderson
2024-04-08 8:48 ` Paolo Bonzini
2024-04-04 19:47 ` [PATCH-for-9.1 3/7] monitor: Rework stubs to simplify user emulation linking Philippe Mathieu-Daudé
2024-04-08 9:50 ` Paolo Bonzini
2024-04-08 10:59 ` Philippe Mathieu-Daudé [this message]
2024-04-04 19:47 ` [PATCH-for-9.1 4/7] util/qemu-config: Extract QMP commands to qemu-config-qmp.c Philippe Mathieu-Daudé
2024-04-08 8:50 ` Paolo Bonzini
2024-04-04 19:47 ` [PATCH-for-9.1 5/7] hw/core: Restrict reset handlers API to system emulation Philippe Mathieu-Daudé
2024-04-08 10:09 ` Paolo Bonzini
2024-04-04 19:47 ` [PATCH-for-9.1 6/7] hw/core: Move reset.c to hwcore_ss[] source set Philippe Mathieu-Daudé
2024-04-05 22:44 ` Richard Henderson
2024-04-08 6:00 ` Philippe Mathieu-Daudé
2024-04-04 19:47 ` [PATCH-for-9.1 7/7] hw: Include minimal source set in user emulation build Philippe Mathieu-Daudé
2024-04-05 22:45 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521b4a1c-2762-4dc7-b9fa-ffa6a8250a13@linaro.org \
--to=philmd@linaro.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).