Re: [Qemu-devel] [PATCH v3 3/3] vfio: Fix 128 bit handling

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 08/29/2013 06:50 PM, Paolo Bonzini wrote:
> Il 29/08/2013 08:58, Alexey Kardashevskiy ha scritto:
>> On 08/29/2013 04:29 PM, Paolo Bonzini wrote:
>>> Il 29/08/2013 04:26, Alexey Kardashevskiy ha scritto:
>>>>
>>>> Right. I was planning to add my IOMMU stuff right before calculating @end.
>>>
>>> But then the non-IOMMU stuff can just use int128_get64, no?  So even if
>>> this patch simply uses int128_get64, it is still a suitable basis for
>>> adding IOMMU stuff.
>>
>> Suitable but ugly. What if before calling int128_get64, I test
>> section->size if it is <2^64 and only then do RAM part of this function?
> 
> What if you just merge the two series together?

It will still be a function which can accept sections bigger than 2^64 and
theoretically call int128_get64() and assert. I would think that every time
when anyone calls int128_get64(), the value should be checked for <2^64. It
is like division by zero :)



-- 
Alexey