From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 08/21] block: expect errors from bdrv_co_is_allocated
Date: Fri, 30 Aug 2013 09:18:28 +0200 [thread overview]
Message-ID: <52204744.4000900@redhat.com> (raw)
In-Reply-To: <521FBEA2.3090703@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 29/08/2013 23:35, Eric Blake ha scritto:
> block-migration.c uses !bdrv_is_allocated as a condition for a
> while loop; should that check for errors?
Not needed, in case of an error it will exit the loop and read the
sector. This will probably cause another error that will be
reported---or if it succeeds, it's safe and may in the worst case
cause extra data to be migrated.
> block/vvfat.c contains an if (bdrv_is_allocated(...)); should that
> handle errors?
No idea, vvfat is black magic. :(
Paolo
> If you can justify that those don't need changes, then I'm okay
> with:
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSIEdEAAoJEBvWZb6bTYbyTtYQAIb2BUcJMjAU/ULufDA4rDNt
SRh0NhXIdAM+G34PhE9WbhJ06DUtaa6T8nnHWnx70w0PR8XIDE1BUZDdC1AZv6st
ebsNSFB4KIVSH0zKgeMD20qLnJcVpVPlxNHmbCs9odnLUgMGF2+2n64j/zRvc/RW
H0l4DWZFknwapqcfSV4w8Idh4t/ma6HG9hkYNhNVam9eEaOWPFLGJosTQ5HeIvhU
n8kZrECzv5GzXmf301E+QUmti3igfAevwc5rNAbj1pzPzbZJD58WLWXZVsrVV8VR
QC8ABSTpMR+O3mjMexX/Bymg9jSZYAD5q47wXFnZSh0XOhzAiGuokLts2hkTYH2H
xxbRhFiNgxp7qjIHDMAvUqilwDx01JKzjtosKlcAFRfidklOMBdOCLz3Q6vN4JmH
DOb5nb9EjjORoAiveA3EqOOHUA9QNzsfkKr6ql94sJQZP4YUHg7dJwamXzqbxVys
Szu1wVhe2LB0BYjx+uKuxREaU+F++c36TKM7ilIlXje4TucbhGzunEy2O1Wynz9i
39zZe4fhSXoNpQHu5qjzP20y3l/wbMXXdYnq/x+ey9h4Gxcpd/IBecUtUQffd/SQ
acrtoWZUaCeWeSM0PXPt3oJr2pqFQnzhIxE34mP82mpdsrjEJXYhnVSwsVf/CecQ
nSiNzu/gWraEutp/6vcE
=tb+T
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-08-30 7:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 14:00 [Qemu-devel] [PATCH v4 00/21] Add qemu-img subcommand to dump file metadata Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 01/21] cow: make reads go at a decent speed Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 02/21] cow: make writes go at a less indecent speed Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 03/21] cow: do not call bdrv_co_is_allocated Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 04/21] block: keep bs->total_sectors up to date even for growable block devices Paolo Bonzini
2013-08-29 19:51 ` Eric Blake
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 05/21] block: make bdrv_co_is_allocated static Paolo Bonzini
2013-08-29 19:53 ` Eric Blake
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 06/21] block: do not use ->total_sectors in bdrv_co_is_allocated Paolo Bonzini
2013-08-29 19:58 ` Eric Blake
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 07/21] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 08/21] block: expect errors from bdrv_co_is_allocated Paolo Bonzini
2013-08-29 21:35 ` Eric Blake
2013-08-30 7:18 ` Paolo Bonzini [this message]
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 09/21] qemu-img: always probe the input image for allocated sectors Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 10/21] block: make bdrv_has_zero_init return false for copy-on-write-images Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 11/21] block: introduce bdrv_get_block_status API Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 12/21] block: define get_block_status return value Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 13/21] block: return get_block_status data and flags for formats Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 14/21] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 15/21] block: return BDRV_BLOCK_ZERO past end of backing file Paolo Bonzini
2013-08-29 21:59 ` Eric Blake
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 16/21] qemu-img: add a "map" subcommand Paolo Bonzini
2013-08-29 22:49 ` Eric Blake
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 17/21] docs, qapi: document qemu-img map Paolo Bonzini
2013-08-29 15:31 ` Eric Blake
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 18/21] raw-posix: return get_block_status data and flags Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 19/21] raw-posix: report unwritten extents as zero Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 20/21] block: add default get_block_status implementation for protocols Paolo Bonzini
2013-08-29 14:00 ` [Qemu-devel] [PATCH v4 21/21] block: look for zero blocks in bs->file Paolo Bonzini
2013-09-04 15:50 ` [Qemu-devel] [PATCH v4 00/21] Add qemu-img subcommand to dump file metadata Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52204744.4000900@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).