From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFIyh-0002mT-Mt for qemu-devel@nongnu.org; Fri, 30 Aug 2013 03:18:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFIyc-0003zE-3r for qemu-devel@nongnu.org; Fri, 30 Aug 2013 03:18:43 -0400 Sender: Paolo Bonzini Message-ID: <52204744.4000900@redhat.com> Date: Fri, 30 Aug 2013 09:18:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377784821-29561-1-git-send-email-pbonzini@redhat.com> <1377784821-29561-9-git-send-email-pbonzini@redhat.com> <521FBEA2.3090703@redhat.com> In-Reply-To: <521FBEA2.3090703@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 08/21] block: expect errors from bdrv_co_is_allocated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 29/08/2013 23:35, Eric Blake ha scritto: > block-migration.c uses !bdrv_is_allocated as a condition for a > while loop; should that check for errors? Not needed, in case of an error it will exit the loop and read the sector. This will probably cause another error that will be reported---or if it succeeds, it's safe and may in the worst case cause extra data to be migrated. > block/vvfat.c contains an if (bdrv_is_allocated(...)); should that > handle errors? No idea, vvfat is black magic. :( Paolo > If you can justify that those don't need changes, then I'm okay > with: > > Reviewed-by: Eric Blake -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSIEdEAAoJEBvWZb6bTYbyTtYQAIb2BUcJMjAU/ULufDA4rDNt SRh0NhXIdAM+G34PhE9WbhJ06DUtaa6T8nnHWnx70w0PR8XIDE1BUZDdC1AZv6st ebsNSFB4KIVSH0zKgeMD20qLnJcVpVPlxNHmbCs9odnLUgMGF2+2n64j/zRvc/RW H0l4DWZFknwapqcfSV4w8Idh4t/ma6HG9hkYNhNVam9eEaOWPFLGJosTQ5HeIvhU n8kZrECzv5GzXmf301E+QUmti3igfAevwc5rNAbj1pzPzbZJD58WLWXZVsrVV8VR QC8ABSTpMR+O3mjMexX/Bymg9jSZYAD5q47wXFnZSh0XOhzAiGuokLts2hkTYH2H xxbRhFiNgxp7qjIHDMAvUqilwDx01JKzjtosKlcAFRfidklOMBdOCLz3Q6vN4JmH DOb5nb9EjjORoAiveA3EqOOHUA9QNzsfkKr6ql94sJQZP4YUHg7dJwamXzqbxVys Szu1wVhe2LB0BYjx+uKuxREaU+F++c36TKM7ilIlXje4TucbhGzunEy2O1Wynz9i 39zZe4fhSXoNpQHu5qjzP20y3l/wbMXXdYnq/x+ey9h4Gxcpd/IBecUtUQffd/SQ acrtoWZUaCeWeSM0PXPt3oJr2pqFQnzhIxE34mP82mpdsrjEJXYhnVSwsVf/CecQ nSiNzu/gWraEutp/6vcE =tb+T -----END PGP SIGNATURE-----