From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFJAP-0007bO-6o for qemu-devel@nongnu.org; Fri, 30 Aug 2013 03:30:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFJAG-0007qA-92 for qemu-devel@nongnu.org; Fri, 30 Aug 2013 03:30:49 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:52779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFJAF-0007pp-L1 for qemu-devel@nongnu.org; Fri, 30 Aug 2013 03:30:40 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 30 Aug 2013 17:19:14 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 61794357804E for ; Fri, 30 Aug 2013 17:30:28 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7U7EJT948890016 for ; Fri, 30 Aug 2013 17:14:20 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7U7URCe000539 for ; Fri, 30 Aug 2013 17:30:27 +1000 Message-ID: <52204A08.6060706@linux.vnet.ibm.com> Date: Fri, 30 Aug 2013 15:30:16 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1374584606-5615-1-git-send-email-kwolf@redhat.com> <1374584606-5615-3-git-send-email-kwolf@redhat.com> <20130821033805.GA7028@amosk.info> <20130827155859.GP648@dhcp-200-207.str.redhat.com> <20130829095247.526626e5@redhat.com> <20130829160650.GA2435@dhcp-200-207.str.redhat.com> <20130829123315.63432366@redhat.com> <521F7EA2.90303@redhat.com> <20130829143618.50c1f8a9@redhat.com> In-Reply-To: <20130829143618.50c1f8a9@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com, Amos Kong 于 2013-8-30 2:36, Luiz Capitulino 写道: > On Thu, 29 Aug 2013 11:02:26 -0600 > Eric Blake wrote: > >> On 08/29/2013 10:33 AM, Luiz Capitulino wrote: >> >>>>> >>>>> Strange, it appears on your pull request... But anyway, your series >>>>> made it into 1.6.0, so I think we'll need the missing patch in 1.6.1 too? >>>> >>>> There's no user in 1.6 (or would we have a build failure) because I >>>> didn't merge blockdev-add, so I guess it doesn't matter. >>> >>> I won't say it's a huge deal, but any downstreamers basing on 1.6 will >>> have a hard time if they backport blockdev-add or any future command >>> that my depend on this. >> >> Any downstreamers that plans to backport blockdev-add would also >> backport this as part of their efforts. I don't see that as any >> different from any other backport effort that includes requiring >> multiple non-contiguous pre-req patches. > > Backport work can be hard. I'd praise people for making it easier > for me and would curse people for making it harder for no reason. > >> We don't need it on the 1.6 >> stable tree, and downstream is no worse for the wear. > > Why is the feature there in the first place then? > Guess it is for a better way to enable Fam Zheng's point in time block snapshot, which need to create a temporary BDS. This series provide a more general way to manage the BDS life cycle? I just noticed this series, it seems an example as a block layer interface design, looking forward to V2. -- Best Regards Wenchao Xia