From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFLa6-0000tU-Dz for qemu-devel@nongnu.org; Fri, 30 Aug 2013 06:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFLa0-0000CJ-Hv for qemu-devel@nongnu.org; Fri, 30 Aug 2013 06:05:30 -0400 Sender: Paolo Bonzini Message-ID: <52206E51.4090502@redhat.com> Date: Fri, 30 Aug 2013 12:05:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377856725-32644-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1377856725-32644-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: fix disassembly with PAE=1, PG=0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-stable@nongnu.org Cc: qemu-devel@nongnu.org, Richard Henderson Il 30/08/2013 11:58, Paolo Bonzini ha scritto: > CR4.PAE=1 will not enable paging if CR0.PG=0, but the "if" chain > in x86_cpu_get_phys_page_debug says otherwise. Check CR0.PG > before everything else. > > Fixes "-d in_asm" for a code section at the beginning of OVMF. > > Cc: Richard Henderson > Signed-off-by: Paolo Bonzini > --- > target-i386/helper.c | 34 ++++++++++++++++------------------ > 1 file changed, 16 insertions(+), 18 deletions(-) > > diff --git a/target-i386/helper.c b/target-i386/helper.c > index bf3e2ac..7f74e5d 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -894,7 +894,10 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) > uint32_t page_offset; > int page_size; > > - if (env->cr[4] & CR4_PAE_MASK) { > + if (!(env->cr[0] & CR0_PG_MASK)) { > + pte = addr & env->a20_mask; > + page_size = 4096; > + } else if (env->cr[4] & CR4_PAE_MASK) { > target_ulong pdpe_addr; > uint64_t pde, pdpe; > > @@ -952,26 +955,21 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) > } else { > uint32_t pde; > > - if (!(env->cr[0] & CR0_PG_MASK)) { > - pte = addr; > - page_size = 4096; > + /* page directory entry */ > + pde_addr = ((env->cr[3] & ~0xfff) + ((addr >> 20) & 0xffc)) & env->a20_mask; > + pde = ldl_phys(pde_addr); > + if (!(pde & PG_PRESENT_MASK)) > + return -1; > + if ((pde & PG_PSE_MASK) && (env->cr[4] & CR4_PSE_MASK)) { > + pte = pde & ~0x003ff000; /* align to 4MB */ > + page_size = 4096 * 1024; > } else { > /* page directory entry */ > - pde_addr = ((env->cr[3] & ~0xfff) + ((addr >> 20) & 0xffc)) & env->a20_mask; > - pde = ldl_phys(pde_addr); > - if (!(pde & PG_PRESENT_MASK)) > + pte_addr = ((pde & ~0xfff) + ((addr >> 10) & 0xffc)) & env->a20_mask; > + pte = ldl_phys(pte_addr); > + if (!(pte & PG_PRESENT_MASK)) > return -1; > - if ((pde & PG_PSE_MASK) && (env->cr[4] & CR4_PSE_MASK)) { > - pte = pde & ~0x003ff000; /* align to 4MB */ > - page_size = 4096 * 1024; > - } else { > - /* page directory entry */ > - pte_addr = ((pde & ~0xfff) + ((addr >> 10) & 0xffc)) & env->a20_mask; > - pte = ldl_phys(pte_addr); > - if (!(pte & PG_PRESENT_MASK)) > - return -1; > - page_size = 4096; > - } > + page_size = 4096; > } > pte = pte & env->a20_mask; > } > Should also go in qemu-stable. Paolo